Page MenuHomePhabricator
Differential D590

Convert bitcoin-tx and utilmoneystr to use Amount struct.
ClosedPublic
Actions

Authored by schancel on Oct 8 2017, 20:43.

Details

Reviewers
freetrader
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2aa14e43ad97: Convert bitcoin-tx and utilmoneystr to use Amount struct.
rABC2aa14e43ad97: Convert bitcoin-tx and utilmoneystr to use Amount struct.
Summary

This diff patches bitcoin-tx and utilmoneystr to use the
Amount struct instead of the previous CAmount typedef.

Test Plan

make VERBOSE=1 check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
shammah/amount2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 961
Build 961: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 8 2017, 20:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2017, 20:43
schancel updated this revision to Diff 1517.Oct 8 2017, 21:00
  • Switch constant values for fees to Amount as well.
deadalnix requested changes to this revision.Oct 8 2017, 22:53
deadalnix added inline comments.
src/init.cpp
724 ↗(On Diff #1517)

Just make all these constant Amount.

src/test/util_tests.cpp
183 ↗(On Diff #1517)

You should not be able to assign an int to an Amount.

This revision now requires changes to proceed.Oct 8 2017, 22:53
schancel added inline comments.Oct 9 2017, 17:27
src/test/util_tests.cpp
183 ↗(On Diff #1517)

I'll fix that as the last patch when I make the constructors explicit.

schancel updated this revision to Diff 1523.Oct 9 2017, 17:29
schancel edited edge metadata.
  • Convert several more constants to be of type Amount
deadalnix accepted this revision.Oct 9 2017, 17:40
This revision is now accepted and ready to land.Oct 9 2017, 17:40
Closed by commit rABC2aa14e43ad97: Convert bitcoin-tx and utilmoneystr to use Amount struct. (authored by schancel, committed by schancel). · Explain WhyOct 9 2017, 18:41
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
45 lines
21 lines
2 lines
policy/
6 lines
test/
40 lines
6 lines
9 lines
2 lines
wallet/
10 lines

Diff 1516

View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/utilmoneystr.h

Loading...
View Options

src/utilmoneystr.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...