Convert bitcoin-tx and utilmoneystr to use Amount struct.
ClosedPublic
Actions

Authored by schancel on Oct 8 2017, 20:43.

Details

Reviewers

freetrader
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING2aa14e43ad97: Convert bitcoin-tx and utilmoneystr to use Amount struct.
rABC2aa14e43ad97: Convert bitcoin-tx and utilmoneystr to use Amount struct.

Summary

This diff patches bitcoin-tx and utilmoneystr to use the
Amount struct instead of the previous CAmount typedef.

Test Plan

make VERBOSE=1 check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

shammah/amount2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 962
Build 962: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 8 2017, 20:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2017, 20:43

Switch constant values for fees to Amount as well.

deadalnix requested changes to this revision.Oct 8 2017, 22:53

deadalnix added inline comments.

src/init.cpp
724	Just make all these constant Amount.
src/test/util_tests.cpp
183	You should not be able to assign an int to an Amount.

This revision now requires changes to proceed.Oct 8 2017, 22:53

schancel added inline comments.Oct 9 2017, 17:27

src/test/util_tests.cpp
183	I'll fix that as the last patch when I make the constructors explicit.

Convert several more constants to be of type Amount

deadalnix accepted this revision.Oct 9 2017, 17:40

This revision is now accepted and ready to land.Oct 9 2017, 17:40

Closed by commit rABC2aa14e43ad97: Convert bitcoin-tx and utilmoneystr to use Amount struct. (authored by schancel, committed by schancel). · Explain WhyOct 9 2017, 18:41

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

45 lines

21 lines

4 lines

2 lines

policy/

policy.h

6 lines

policy.cpp

5 lines

test/

miner_tests.cpp

3 lines

transaction_tests.cpp

2 lines

40 lines

6 lines

9 lines

2 lines

2 lines

wallet/

wallet.cpp

10 lines

Diff 1517

View Options

src/bitcoin-tx.cpp

View Options

src/init.cpp

View Options

src/miner.cpp

View Options

src/net_processing.cpp

View Options

src/policy/policy.h

View Options

src/policy/policy.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/utilmoneystr.h

View Options

src/utilmoneystr.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

Convert bitcoin-tx and utilmoneystr to use Amount struct.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1517

src/bitcoin-tx.cpp

src/init.cpp

src/miner.cpp

src/net_processing.cpp

src/policy/policy.h

src/policy/policy.cpp

src/test/miner_tests.cpp

src/test/transaction_tests.cpp

src/test/util_tests.cpp

src/utilmoneystr.h

src/utilmoneystr.cpp

src/validation.h

src/validation.cpp

src/wallet/wallet.cpp

Convert bitcoin-tx and utilmoneystr to use Amount struct.
ClosedPublic
Actions

Revision Contents
Changeset List