Page MenuHomePhabricator
Differential D5916

Finish passing rpcwallet RPCs Results and Examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 30 2020, 18:29.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING70ba2634e165: Finish passing rpcwallet RPCs Results and Examples to RPCHelpMan
rABC70ba2634e165: Finish passing rpcwallet RPCs Results and Examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rpcwallet4.diff

Verify changes in rpcwallet4.diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

rpcwallet4.diff:

rpcwallet4.diff2 KBDownload

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 30 2020, 18:29
Owners added a reviewer: Restricted Owners Package.Apr 30 2020, 18:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2020, 18:29
nakihito planned changes to this revision.Apr 30 2020, 18:29
teamcity edited the summary of this revision. (Show Details)Apr 30 2020, 18:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the test plan for this revision. (Show Details)Apr 30 2020, 18:31
teamcity added a comment.Apr 30 2020, 18:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster failed remote builds in B10520: Diff 19314!Apr 30 2020, 18:40
teamcity added a comment.Apr 30 2020, 18:40
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

2020-04-30T18:39:28.542000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200430_183801/feature_uacomment_564/test_framework.log
2020-04-30T18:39:28.542000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200430_183801/feature_uacomment_564' to consolidate all logs
[18:39:57]i:		 [Bitcoin ABC functional tests] wallet_multiwallet.py
[18:39:57]i:			 [wallet_multiwallet.py] [Test Output]
2020-04-30T18:38:55.133000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/bitcoin_test_runner_20200430_183801/wallet_multiwallet_536
2020-04-30T18:38:57.474000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 352, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 237, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 165, in main
    self.run_test()
  File "/work/test/functional/wallet_multiwallet.py", line 93, in run_test
    ['-walletdir=wallets'], 'Error: Specified -walletdir "wallets" does not exist')
  File "/work/test/functional/test_framework/test_node.py", line 375, in assert_start_raises_init_error
    'Expected message "{}" does not fully match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 152, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Error: Specified -walletdir "wallets" does not exist" does not fully match stderr:
"ErrorSpecified -walletdir "wallets" does not exist"
2020-04-30T18:38:57.525000Z TestFramework (INFO): Stopping nodes
2020-04-30T18:38:57.525000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200430_183801/wallet_multiwallet_536
2020-04-30T18:38:57.525000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200430_183801/wallet_multiwallet_536/test_framework.log
2020-04-30T18:38:57.525000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200430_183801/wallet_multiwallet_536' to consolidate all logs
[18:39:57]i:		 [Bitcoin ABC functional tests] wallet_multiwallet.py --usecli
[18:39:57]i:			 [wallet_multiwallet.py --usecli] [Test Output]
2020-04-30T18:38:44.016000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/bitcoin_test_runner_20200430_183801/wallet_multiwallet_530
2020-04-30T18:38:46.136000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 352, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 237, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 165, in main
    self.run_test()
  File "/work/test/functional/wallet_multiwallet.py", line 93, in run_test
    ['-walletdir=wallets'], 'Error: Specified -walletdir "wallets" does not exist')
  File "/work/test/functional/test_framework/test_node.py", line 375, in assert_start_raises_init_error
    'Expected message "{}" does not fully match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 152, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Error: Specified -walletdir "wallets" does not exist" does not fully match stderr:
"ErrorSpecified -walletdir "wallets" does not exist"
2020-04-30T18:38:46.188000Z TestFramework (INFO): Stopping nodes
2020-04-30T18:38:46.188000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200430_183801/wallet_multiwallet_530
2020-04-30T18:38:46.188000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200430_183801/wallet_multiwallet_530/test_framework.log
2020-04-30T18:38:46.188000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200430_183801/wallet_multiwallet_530' to consolidate all logs
[18:40:05]W:	 [Step 1/2] Process exited with code 1
[18:40:05]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Each failure log is accessible here:
Bitcoin ABC functional tests: abc-cmdline.py
Bitcoin ABC functional tests: feature_blocksdir.py
Bitcoin ABC functional tests: feature_config_args.py
Bitcoin ABC functional tests: feature_includeconf.py
Bitcoin ABC functional tests: feature_logging.py
Bitcoin ABC functional tests: feature_uacomment.py
Bitcoin ABC functional tests: wallet_multiwallet.py
Bitcoin ABC functional tests: wallet_multiwallet.py --usecli

nakihito updated this revision to Diff 19318.Apr 30 2020, 20:38

Rebased.

teamcity added a comment.Apr 30 2020, 20:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 30 2020, 20:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10523: Diff 19318.Apr 30 2020, 20:52
nakihito added a child revision: D5922: Finish PR14987 and clean up some functions.Apr 30 2020, 21:27
deadalnix requested changes to this revision.May 1 2020, 00:44
deadalnix added a subscriber: deadalnix.

rebase

This revision now requires changes to proceed.May 1 2020, 00:44
nakihito updated this revision to Diff 19338.May 1 2020, 00:59

Rebased.

teamcity added a comment.May 1 2020, 01:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 1 2020, 01:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10538: Diff 19338.May 1 2020, 01:10
deadalnix accepted this revision.May 1 2020, 12:33
This revision is now accepted and ready to land.May 1 2020, 12:33
Closed by commit rABC70ba2634e165: Finish passing rpcwallet RPCs Results and Examples to RPCHelpMan (authored by nakihito). · Explain WhyMay 1 2020, 22:24
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC70ba2634e165: Finish passing rpcwallet RPCs Results and Examples to RPCHelpMan.
nakihito added a commit: rSTAGING70ba2634e165: Finish passing rpcwallet RPCs Results and Examples to RPCHelpMan.May 5 2020, 19:16

Revision Contents
Changeset List

PathSize
src/
wallet/
1281 lines

Diff 19359

View Options

src/wallet/rpcwallet.cpp

Loading...