Page MenuHomePhabricator

Finish PR14987 and clean up some functions
ClosedPublic

Authored by nakihito on Apr 30 2020, 21:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe55251f4329b: Finish PR14987 and clean up some functions
rABCe55251f4329b: Finish PR14987 and clean up some functions
Summary

Removes now unnecessary functions, etc. from the portioned backporting
of PR14987.

Depends on D5291, D5290, D5919, D5916, D5914, D5913, D5899

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched finish.diff

Verify finish.diff does not exist.

Scripts:


Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 30 2020, 21:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 1 2020, 00:47
This revision was automatically updated to reflect the committed changes.