Page MenuHomePhabricator
Differential D5919

Pass rpc/avalanche Results and Examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 30 2020, 20:58.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGdf9019c00825: Pass rpc/avalanche Results and Examples to RPCHelpMan
rABCdf9019c00825: Pass rpc/avalanche Results and Examples to RPCHelpMan
Summary

Changes consistent with PR14987.

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched avalanche.diff

Verify avalanche.diff doesn't exist.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-avalanche
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10525
Build 18864: Default Diff Build & Tests
Build 18863: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 30 2020, 20:58
Owners added a reviewer: Restricted Owners Package.Apr 30 2020, 20:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2020, 20:58
teamcity edited the summary of this revision. (Show Details)Apr 30 2020, 20:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 30 2020, 20:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 30 2020, 21:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10525: Diff 19320.Apr 30 2020, 21:07
nakihito added a child revision: D5922: Finish PR14987 and clean up some functions.Apr 30 2020, 21:27
jasonbcox accepted this revision.Apr 30 2020, 22:32
This revision is now accepted and ready to land.Apr 30 2020, 22:32
Closed by commit rABCdf9019c00825: Pass rpc/avalanche Results and Examples to RPCHelpMan (authored by nakihito). · Explain WhyMay 1 2020, 01:04
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCdf9019c00825: Pass rpc/avalanche Results and Examples to RPCHelpMan.
nakihito added a commit: rSTAGINGdf9019c00825: Pass rpc/avalanche Results and Examples to RPCHelpMan.May 5 2020, 19:16

Revision Contents
Changeset List

PathSize
src/
rpc/
39 lines

Diff 19320

View Options

src/rpc/avalanche.cpp

Loading...