Remove dead code in core_memusage.h
ClosedPublic
Actions

Authored by Fabien on May 7 2020, 08:59.

Details

Reviewers

deadalnix
majcosta

Group Reviewers

Restricted Project

Commits

rSTAGINGf2fb9de5cde7: Remove dead code in core_memusage.h
rABCf2fb9de5cde7: Remove dead code in core_memusage.h

Summary

The dynamic usage of blocks and block locators is never used.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove_dead_dynamic_usage

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10632
Build 19071: Default Diff Build & Tests
Build 19070: arc lint + arc unit

Event Timeline

Fabien created this revision.May 7 2020, 08:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2020, 08:59

Fabien requested review of this revision.May 7 2020, 08:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10632: Diff 19783.May 7 2020, 09:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

deadalnix accepted this revision.May 7 2020, 14:27

This revision is now accepted and ready to land.May 7 2020, 14:27

majcosta accepted this revision.May 7 2020, 14:29

Closed by commit rABCf2fb9de5cde7: Remove dead code in core_memusage.h (authored by Fabien). · Explain WhyMay 7 2020, 14:46

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf2fb9de5cde7: Remove dead code in core_memusage.h.

Fabien added a commit: rSTAGINGf2fb9de5cde7: Remove dead code in core_memusage.h.May 7 2020, 14:50

Fabien mentioned this in D8636: tests: Add deserialization fuzzing of SnapshotMetadata (utxo_snapshot). Increase fuzzing coverage..Dec 9 2020, 15:05

Fabien mentioned this in rABC7ef95976cd28: tests: Add deserialization fuzzing of SnapshotMetadata (utxo_snapshot)..Dec 9 2020, 15:44

Revision Contents
Changeset List

Path

Size

src/

core_memusage.h

12 lines

Diff 19783

View Options

Remove dead code in core_memusage.hClosedPublicActions