Page MenuHomePhabricator
Differential D6022

Restrict setmocktime to non-negative integers
ClosedPublic
Actions

Authored by jasonbcox on May 10 2020, 20:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING6bd6615b8135: Restrict setmocktime to non-negative integers
rABC6bd6615b8135: Restrict setmocktime to non-negative integers
Summary

The assumption that now > 0 is applied throughout util/time.cpp,
so there's no reason to expect setting mock time to a negative int to be valid.

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
neg-mocktime
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10678
Build 19153: Default Diff Build & Tests
Build 19152: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 10 2020, 20:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 10 2020, 20:19
jasonbcox requested review of this revision.May 10 2020, 20:19
teamcity added a comment.May 10 2020, 20:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 10 2020, 20:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10678: Diff 19876.May 10 2020, 20:34
jasonbcox added a child revision: D6024: [net] Ignore unlikely timestamps in version messages.May 11 2020, 02:52
Fabien accepted this revision.May 11 2020, 07:23
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/misc.cpp
336

Nit: "Timestamp must be a positive integer" tells what it should be rather that what is should not be.

This revision is now accepted and ready to land.May 11 2020, 07:23
jasonbcox updated this revision to Diff 19892.May 11 2020, 16:52

Tweaked error message text

teamcity added a comment.May 11 2020, 16:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 11 2020, 17:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10690: Diff 19892.May 11 2020, 17:02
Closed by commit rABC6bd6615b8135: Restrict setmocktime to non-negative integers (authored by jasonbcox). · Explain WhyMay 11 2020, 17:03
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC6bd6615b8135: Restrict setmocktime to non-negative integers.
jasonbcox added a commit: rSTAGING6bd6615b8135: Restrict setmocktime to non-negative integers.
PiRK mentioned this in D11788: Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime.Jul 22 2022, 07:20
PiRK mentioned this in rABC10843101904e: Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime.Jul 22 2022, 09:59

Revision Contents
Changeset List

PathSize
src/
rpc/
7 lines
util/
1 line
test/
functional/
28 lines

Diff 19876

View Options

src/rpc/misc.cpp

Loading...
View Options

src/util/time.cpp

Loading...
View Options

test/functional/abc-rpc-mocktime.py

Loading...