Page MenuHomePhabricator
Differential D6044

[backport#13932] Implement joinpsbts RPC and tests
ClosedPublic
Actions

Authored by majcosta on May 12 2020, 20:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf283c36d3a0f: [backport#13932] Implement joinpsbts RPC and tests
rABCf283c36d3a0f: [backport#13932] Implement joinpsbts RPC and tests
Summary

Adds a joinpsbts RPC which combines multiple distinct PSBTs into
one PSBT.

https://github.com/bitcoin/bitcoin/pull/13932/commits/08f749c9147a5f3fdbbd880e0974b97084429002

Depends on D6043

This is a partial backport of Core PR13932 plus a test case

Test Plan
ninja check
test_runner.py rpc_psbt

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13932
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10718
Build 19229: Default Diff Build & Tests
Build 19228: arc lint + arc unit

Event Timeline

majcosta created this revision.May 12 2020, 20:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2020, 20:08
majcosta requested review of this revision.May 12 2020, 20:08
teamcity edited the summary of this revision. (Show Details)May 12 2020, 20:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 12 2020, 20:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10718: Diff 19957.May 12 2020, 20:19
teamcity added a comment.May 12 2020, 20:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

majcosta added a child revision: D6045: [backport#13932] Move PSBT UTXO fetching to a separate method.May 12 2020, 20:25
deadalnix accepted this revision.May 12 2020, 20:57
This revision is now accepted and ready to land.May 12 2020, 20:57
Closed by commit rABCf283c36d3a0f: [backport#13932] Implement joinpsbts RPC and tests (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyMay 13 2020, 14:05
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCf283c36d3a0f: [backport#13932] Implement joinpsbts RPC and tests.
majcosta added a commit: rSTAGINGf283c36d3a0f: [backport#13932] Implement joinpsbts RPC and tests.May 13 2020, 14:10

Revision Contents
Changeset List

PathSize
src/
2 lines
19 lines
rpc/
1 line
82 lines
test/
functional/
29 lines

Diff 19957

View Options

src/psbt.h

Loading...
View Options

src/psbt.cpp

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...