Page MenuHomePhabricator

Bump PORT_MIN in test framework to not collide with testnet
ClosedPublic

Authored by jasonbcox on May 14 2020, 19:41.

Details

Summary

As we add more functional tests, it becomes increasingly likely to see flaky failures if you
happen to be running a testnet node (default port 18333) while running functional tests on
the same machine. This is due to the p2p port range of the test suite being 16000 - 21000
which overlaps. Although doing so is not recommended, there's no reason for us to knowingly
produce this flaky situation when all of these port numbers are under our control.

This patch bumps PORT_MIN so that the new rpc port range is 20000 - 25000 and the p2p port
range is 25000 - 30000.

Depends on D6075 just to bring us up-to-date with Core before making this small diversion.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.May 14 2020, 19:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 19:41
jasonbcox requested review of this revision.May 14 2020, 19:41
Fabien accepted this revision.May 14 2020, 19:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/util.py
276 ↗(On Diff #20058)

Maybe add a comment to explain 20000>18333

This revision is now accepted and ready to land.May 14 2020, 19:44
jasonbcox updated this revision to Diff 20065.May 14 2020, 19:53

Add comment per feedback

nakihito accepted this revision.May 14 2020, 19:56