Page MenuHomePhabricator
Differential D6079

[backport#15508] Refactor analyzepsbt for use outside RPC code
ClosedPublic
Actions

Authored by majcosta on May 14 2020, 21:13.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGING27384f6968a8: [backport#15508] Refactor analyzepsbt for use outside RPC code
rABC27384f6968a8: [backport#15508] Refactor analyzepsbt for use outside RPC code
Summary

Refactor the analyzepsbt RPC into (1) an AnalyzePSBT function, which returns
its output as a new strongly-typed PSBTAnalysis struct, and (2) a thin wrapper
which converts the struct into a UniValue for RPC use.

https://github.com/bitcoin/bitcoin/pull/15508/commits/ef22fe8c1f331b4f13f21a54d12030b92e83fbe7

Depends on D6077

This is a partial backport of Core PR15508

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 14 2020, 21:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 21:13
majcosta requested review of this revision.May 14 2020, 21:13
teamcity edited the summary of this revision. (Show Details)May 14 2020, 21:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 14 2020, 21:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 14 2020, 21:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 21:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

majcosta added a child revision: D6080: [backport#15508] Add documentation of struct PSBTAnalysis et al.May 14 2020, 21:17
teamcity added a comment.May 14 2020, 21:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 14 2020, 21:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 14 2020, 21:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10775: Diff 20075.May 14 2020, 21:28
nakihito requested changes to this revision.May 15 2020, 13:59
nakihito added a subscriber: nakihito.
nakihito added inline comments.
src/psbt.h
485 ↗(On Diff #20075)

EXTRACTOR,

This revision now requires changes to proceed.May 15 2020, 13:59
majcosta updated this revision to Diff 20126.May 15 2020, 19:44

addressed comment

teamcity added a comment.May 15 2020, 19:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 15 2020, 19:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 15 2020, 19:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 15 2020, 19:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 15 2020, 19:57

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 15 2020, 20:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10796: Diff 20126.May 15 2020, 20:03
nakihito accepted this revision.May 15 2020, 20:22
This revision is now accepted and ready to land.May 15 2020, 20:22
Closed by commit rABC27384f6968a8: [backport#15508] Refactor analyzepsbt for use outside RPC code (authored by Glenn Willen <gwillen@nerdnet.org>, committed by majcosta). · Explain WhyMay 16 2020, 11:43
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC27384f6968a8: [backport#15508] Refactor analyzepsbt for use outside RPC code.
majcosta added a commit: rSTAGING27384f6968a8: [backport#15508] Refactor analyzepsbt for use outside RPC code.May 16 2020, 11:45
majcosta mentioned this in D6107: [build] enforce exhaustive switch statements in BUILD_WERROR config.May 17 2020, 01:48
majcosta mentioned this in rABC0719259a2eb2: [build] enforce exhaustive switch statements in BUILD_WERROR config.May 17 2020, 16:29
majcosta mentioned this in rSTAGING0719259a2eb2: [build] enforce exhaustive switch statements in BUILD_WERROR config.

Revision Contents
Changeset List

PathSize
src/
39 lines
145 lines
rpc/
164 lines
test/
functional/
2 lines

Diff 20162

View Options

src/psbt.h

Loading...
View Options

src/psbt.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...