Page MenuHomePhabricator

[backport#15508] Refactor analyzepsbt for use outside RPC code
ClosedPublic

Authored by majcosta on May 14 2020, 21:13.

Details

Summary

Refactor the analyzepsbt RPC into (1) an AnalyzePSBT function, which returns
its output as a new strongly-typed PSBTAnalysis struct, and (2) a thin wrapper
which converts the struct into a UniValue for RPC use.

https://github.com/bitcoin/bitcoin/pull/15508/commits/ef22fe8c1f331b4f13f21a54d12030b92e83fbe7


Depends on D6077

This is a partial backport of Core PR15508

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 14 2020, 21:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 21:13
majcosta requested review of this revision.May 14 2020, 21:13
teamcity edited the summary of this revision. (Show Details)May 14 2020, 21:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested changes to this revision.May 15 2020, 13:59
nakihito added a subscriber: nakihito.
nakihito added inline comments.
src/psbt.h
485 ↗(On Diff #20075)

EXTRACTOR,

This revision now requires changes to proceed.May 15 2020, 13:59
majcosta updated this revision to Diff 20126.May 15 2020, 19:44

addressed comment

nakihito accepted this revision.May 15 2020, 20:22
This revision is now accepted and ready to land.May 15 2020, 20:22