Page MenuHomePhabricator
Differential D6096

[backport#15153] wallet: Factor out LoadWallet
ClosedPublic
Actions

Authored by majcosta on May 15 2020, 19:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING65b70e37d66c: [backport#15153] wallet: Factor out LoadWallet
rABC65b70e37d66c: [backport#15153] wallet: Factor out LoadWallet
Summary

https://github.com/bitcoin/bitcoin/pull/15153/commits/17abc0fd52510bfeb85a7b5be04001075ec78b6b

Depends on D6084

This is a partial backport of Core PR15153

Test Plan
cmake .. -GNinja [-DENABLE_BITCOIN_WALLET=OFF]
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 15 2020, 19:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 15 2020, 19:42
majcosta requested review of this revision.May 15 2020, 19:42
teamcity edited the summary of this revision. (Show Details)May 15 2020, 19:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 15 2020, 19:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 15 2020, 19:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 15 2020, 19:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 15 2020, 19:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 15 2020, 19:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 15 2020, 20:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10795: Diff 20125.May 15 2020, 20:06
deadalnix requested changes to this revision.May 16 2020, 01:55
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
3137 ↗(On Diff #20125)

braces

This revision now requires changes to proceed.May 16 2020, 01:55
majcosta updated this revision to Diff 20170.May 16 2020, 13:05

added missing braces

deadalnix accepted this revision.May 16 2020, 13:15
This revision is now accepted and ready to land.May 16 2020, 13:15
teamcity added a comment.May 16 2020, 14:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 16 2020, 14:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 16 2020, 14:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 16 2020, 14:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 16 2020, 14:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 16 2020, 14:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10808: Diff 20170.May 16 2020, 14:35
Closed by commit rABC65b70e37d66c: [backport#15153] wallet: Factor out LoadWallet (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 16 2020, 14:52
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC65b70e37d66c: [backport#15153] wallet: Factor out LoadWallet.
majcosta added a commit: rSTAGING65b70e37d66c: [backport#15153] wallet: Factor out LoadWallet.May 16 2020, 14:55

Revision Contents
Changeset List

PathSize
src/
12 lines
wallet/
18 lines
4 lines
27 lines

Diff 20171

View Options

src/dummywallet.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...