Page MenuHomePhabricator

[backport#15508] Move PSBT decoding functions from core_io to psbt.cpp
ClosedPublic

Authored by majcosta on May 14 2020, 19:56.

Details

Summary

Move PSBT decoding functions from core_io.h/core_read.cpp to psbt.h/psbt.cpp,
to deal with a linker issue.

https://github.com/bitcoin/bitcoin/pull/15508/commits/afd20a25f2937fee8d992c279631fa26cde4a7c8


This is a partial backport of Core PR15508

Test Plan
ninja check
./test/lint/lint-circular-dependencies.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 14 2020, 19:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 19:56
majcosta requested review of this revision.May 14 2020, 19:56
teamcity edited the summary of this revision. (Show Details)May 14 2020, 19:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta edited the test plan for this revision. (Show Details)May 14 2020, 20:54
nakihito accepted this revision.May 14 2020, 20:54
This revision is now accepted and ready to land.May 14 2020, 20:54