Page MenuHomePhabricator
Differential D6121

[backport#15153] Interfaces: Avoid interface instance if wallet is null
ClosedPublic
Actions

Authored by majcosta on May 18 2020, 18:20.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe616c35ce4cf: [backport#15153] Interfaces: Avoid interface instance if wallet is null
rABCe616c35ce4cf: [backport#15153] Interfaces: Avoid interface instance if wallet is null
Summary

https://github.com/bitcoin/bitcoin/pull/15153/commits/4c8982a88e3d9fae4f8fc147a2d9f9650a493da7

Depends on D6119

This is a partial backport of Core PR15153

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 18 2020, 18:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 18:21
majcosta requested review of this revision.May 18 2020, 18:21
teamcity edited the summary of this revision. (Show Details)May 18 2020, 18:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 18 2020, 18:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 18 2020, 18:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 18 2020, 18:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 18 2020, 18:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 18 2020, 18:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 18 2020, 18:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10829: Diff 20220.May 18 2020, 18:30
deadalnix accepted this revision.May 18 2020, 18:42
This revision is now accepted and ready to land.May 18 2020, 18:42
majcosta added a child revision: D6128: [backport#15153] gui: Add OpenWalletActivity.May 18 2020, 23:09
Closed by commit rABCe616c35ce4cf: [backport#15153] Interfaces: Avoid interface instance if wallet is null (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 19 2020, 16:55
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe616c35ce4cf: [backport#15153] Interfaces: Avoid interface instance if wallet is null.
majcosta added a commit: rSTAGINGe616c35ce4cf: [backport#15153] Interfaces: Avoid interface instance if wallet is null.May 19 2020, 17:00

Revision Contents
Changeset List

PathSize
src/
interfaces/
2 lines

Diff 20287

View Options

src/interfaces/wallet.cpp

Loading...