[backport#15153] gui: Add Open Wallet menu
ClosedPublic
Actions

Authored by majcosta on May 18 2020, 15:22.

Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGf4a83401a2f0: [backport#15153] gui: Add Open Wallet menu
rABCf4a83401a2f0: [backport#15153] gui: Add Open Wallet menu

Summary

https://github.com/bitcoin/bitcoin/pull/15153/commits/6c49a55b472fa4ec403e48ec718af85bfd402199

This is a partial backport of Core PR15153

Test Plan

ninja check

./src/qt/bitcoin-qt -regtest -server
./src/bitcoin-cli -regtest createwallet test
./src/bitcoin-cli -regtest unloadwallet test

Changing focus to Open Wallet should reveal 'test', clicking it reveals combobox at right of interface allowing to switch between '[Default wallet]' and 'test'

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 18 2020, 15:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 15:22

majcosta requested review of this revision.May 18 2020, 15:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10823: Diff 20210.May 18 2020, 15:35

Test plan doesn't test the GUI

This revision now requires changes to proceed.May 18 2020, 16:55

corrected test plan to check the UI

majcosta added a child revision: D6119: [backport#15153] gui: Add thread to run background activity in WalletController.May 18 2020, 17:30

You need to test that the thing work, a broken item in the UI doesn't really help.

src/qt/bitcoingui.cpp
426 ↗	(On Diff #20210)	why?

This revision now requires changes to proceed.May 18 2020, 17:30

majcosta edited the test plan for this revision. (Show Details)May 18 2020, 22:24

added a proper test plan

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10838: Diff 20243.May 18 2020, 22:35

majcosta mentioned this in D6129: [backport#15153] gui: Show indeterminate progress dialog while opening wallet.May 18 2020, 23:15

deadalnix accepted this revision.May 18 2020, 23:44

deadalnix added inline comments.

src/qt/bitcoingui.h
146 ↗	(On Diff #20243)	Someone had to be a smartass and use a different style...

deadalnix mentioned this in D6128: [backport#15153] gui: Add OpenWalletActivity.May 18 2020, 23:45

jasonbcox accepted this revision.May 19 2020, 16:01

This revision is now accepted and ready to land.May 19 2020, 16:01

Closed by commit rABCf4a83401a2f0: [backport#15153] gui: Add Open Wallet menu (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 19 2020, 16:54

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCf4a83401a2f0: [backport#15153] gui: Add Open Wallet menu.

majcosta added a commit: rSTAGINGf4a83401a2f0: [backport#15153] gui: Add Open Wallet menu.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.h

1 line

bitcoingui.cpp

20 lines

Diff 20283

View Options

src/qt/bitcoingui.h