Page MenuHomePhabricator

[backport#15153] gui: Add Open Wallet menu
ClosedPublic

Authored by majcosta on May 18 2020, 15:22.

Details

Summary
Test Plan
ninja check

./src/qt/bitcoin-qt -regtest -server
./src/bitcoin-cli -regtest createwallet test
./src/bitcoin-cli -regtest unloadwallet test

Changing focus to Open Wallet should reveal 'test', clicking it reveals combobox at right of interface allowing to switch between '[Default wallet]' and 'test'

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 18 2020, 15:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 15:22
majcosta requested review of this revision.May 18 2020, 15:22
teamcity edited the summary of this revision. (Show Details)May 18 2020, 15:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox requested changes to this revision.May 18 2020, 16:55
jasonbcox added a subscriber: jasonbcox.

Test plan doesn't test the GUI

This revision now requires changes to proceed.May 18 2020, 16:55
majcosta requested review of this revision.May 18 2020, 17:13
majcosta edited the test plan for this revision. (Show Details)

corrected test plan to check the UI

deadalnix requested changes to this revision.May 18 2020, 17:30
deadalnix added a subscriber: deadalnix.

You need to test that the thing work, a broken item in the UI doesn't really help.

src/qt/bitcoingui.cpp
426 ↗(On Diff #20210)

why?

This revision now requires changes to proceed.May 18 2020, 17:30
majcosta edited the test plan for this revision. (Show Details)May 18 2020, 22:24
majcosta updated this revision to Diff 20243.May 18 2020, 22:25

added a proper test plan

deadalnix accepted this revision.May 18 2020, 23:44
deadalnix added inline comments.
src/qt/bitcoingui.h
146 ↗(On Diff #20243)

Someone had to be a smartass and use a different style...

jasonbcox accepted this revision.May 19 2020, 16:01
This revision is now accepted and ready to land.May 19 2020, 16:01