[backport#15153] gui: Show indeterminate progress dialog while opening wallet
ClosedPublic
Actions

Authored by majcosta on May 18 2020, 23:15.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING03ee4b87a741: [backport#15153] gui: Show indeterminate progress dialog while opening wallet
rABC03ee4b87a741: [backport#15153] gui: Show indeterminate progress dialog while opening wallet

Summary

https://github.com/bitcoin/bitcoin/pull/15153/commits/1951ea4342db4122032660139248b79a02c574f3

Depends on D6128

This is a partial backport of Core PR15153

Test Plan

ninja check

Run:

./src/qt/bitcoin-qt -regtest -server
./src/bitcoin-cli -regtest createwallet test
./src/bitcoin-cli -regtest unloadwallet test

Choose: File -> Open Wallet -> test

See a modal with "Opening wallet test" pops up then disappears

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 18 2020, 23:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 23:15

majcosta requested review of this revision.May 18 2020, 23:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10841: Diff 20248.May 18 2020, 23:31

Please detail the test plan. This is useful going forward for people who want to know how to test something as much as it is for you to make sure the code is good.

This revision now requires changes to proceed.May 18 2020, 23:43

corrected test plan

deadalnix accepted this revision.May 19 2020, 17:16

This revision is now accepted and ready to land.May 19 2020, 17:16

Closed by commit rABC03ee4b87a741: [backport#15153] gui: Show indeterminate progress dialog while opening wallet (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 19 2020, 18:59

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC03ee4b87a741: [backport#15153] gui: Show indeterminate progress dialog while opening wallet.

majcosta added a commit: rSTAGING03ee4b87a741: [backport#15153] gui: Show indeterminate progress dialog while opening wallet.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.cpp

25 lines

Diff 20300

View Options

[backport#15153] gui: Show indeterminate progress dialog while opening walletClosedPublicActions