Page MenuHomePhabricator

[backport#15153] gui: Show indeterminate progress dialog while opening wallet
ClosedPublic

Authored by majcosta on May 18 2020, 23:15.

Details

Summary
Test Plan
ninja check

Run:

./src/qt/bitcoin-qt -regtest -server
./src/bitcoin-cli -regtest createwallet test
./src/bitcoin-cli -regtest unloadwallet test

Choose: File -> Open Wallet -> test

See a modal with "Opening wallet test" pops up then disappears

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 18 2020, 23:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 23:15
majcosta requested review of this revision.May 18 2020, 23:15
teamcity edited the summary of this revision. (Show Details)May 18 2020, 23:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 18 2020, 23:43
deadalnix added a subscriber: deadalnix.

Please detail the test plan. This is useful going forward for people who want to know how to test something as much as it is for you to make sure the code is good.

This revision now requires changes to proceed.May 18 2020, 23:43
majcosta requested review of this revision.May 19 2020, 15:36
majcosta edited the test plan for this revision. (Show Details)

corrected test plan

deadalnix accepted this revision.May 19 2020, 17:16
This revision is now accepted and ready to land.May 19 2020, 17:16