Page MenuHomePhabricator

qa: Run more tests with wallet disabled
ClosedPublic

Authored by Fabien on Tue, May 19, 21:06.

Details

Summary
Instead of skipping the whole test, only skip the wallet specific
section of a test if the wallet is not compiled in.

Backport of core PR14324.

Test Plan
ninja check-functional

cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check-functional
  1. Conflicts:
  2. .travis.yml
  3. test/functional/feature_config_args.py
  4. test/functional/feature_notifications.py
  5. test/functional/interface_bitcoin_cli.py
  6. test/functional/interface_zmq.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, May 19, 21:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 19, 21:06
Fabien requested review of this revision.Tue, May 19, 21:06
teamcity edited the summary of this revision. (Show Details)Tue, May 19, 21:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Wed, May 20, 11:38
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/feature_notifications.py
43 ↗(On Diff #20311)

This formatting is bad. When autopep8 does things like this, you should consider manual tweaking.

This revision is now accepted and ready to land.Wed, May 20, 11:38
Fabien updated this revision to Diff 20329.Wed, May 20, 12:19

Work around autopep8

This revision was landed with ongoing or failed builds.Wed, May 20, 12:20
This revision was automatically updated to reflect the committed changes.