scripted-diff: Rename sync_blocks to send_blocks
ClosedPublic
Actions

Authored by Fabien on May 20 2020, 08:48.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGabfb35f181d6: scripted-diff: Rename sync_blocks to send_blocks
rABCabfb35f181d6: scripted-diff: Rename sync_blocks to send_blocks

Summary

...to avoid name collisions and confusion

-BEGIN VERIFY SCRIPT-
FILE_LIST=$(git grep -l 'def sync_blocks' ./test/functional/*.py)
sed -i -e 's/def sync_blocks/def send_blocks/g'   $FILE_LIST
sed -i -e 's/self.sync_blocks/self.send_blocks/g' $FILE_LIST
-END VERIFY SCRIPT-

Partial backport of core PR15773:
https://github.com/bitcoin/bitcoin/pull/15773/commits/fa4680ed0996a7c621265a34392c3eca827b2e48

Test Plan

./test/functional/test_runner.py feature_block feature_csv_activation

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 20 2020, 08:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 08:48

Fabien requested review of this revision.May 20 2020, 08:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Harbormaster completed remote builds in B10875: Diff 20319.May 20 2020, 08:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien added a child revision: D6152: test: Add BitcoinTestFramework::sync_* methods.May 20 2020, 09:58

I think there are naked calls to sync_block remaining. Can you fix this first?

The command in the description were fubared, I had to fix them. Did you run them?

This revision now requires changes to proceed.May 20 2020, 11:42

It's done in D6153, nevermind.

This revision is now accepted and ready to land.May 20 2020, 11:51

Closed by commit rABCabfb35f181d6: scripted-diff: Rename sync_blocks to send_blocks (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyMay 20 2020, 12:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCabfb35f181d6: scripted-diff: Rename sync_blocks to send_blocks.

Fabien added a commit: rSTAGINGabfb35f181d6: scripted-diff: Rename sync_blocks to send_blocks.May 20 2020, 12:25

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_block.py

164 lines

feature_csv_activation.py

64 lines

Diff 20331

View Options

test/functional/feature_block.py