Page MenuHomePhabricator

scripted-diff: Rename sync_blocks to send_blocks
ClosedPublic

Authored by Fabien on Wed, May 20, 08:48.

Details

Summary

...to avoid name collisions and confusion

-BEGIN VERIFY SCRIPT-
FILE_LIST=$(git grep -l 'def sync_blocks' ./test/functional/*.py)
sed -i -e 's/def sync_blocks/def send_blocks/g'   $FILE_LIST
sed -i -e 's/self.sync_blocks/self.send_blocks/g' $FILE_LIST
-END VERIFY SCRIPT-

Partial backport of core PR15773:
https://github.com/bitcoin/bitcoin/pull/15773/commits/fa4680ed0996a7c621265a34392c3eca827b2e48

Test Plan
./test/functional/test_runner.py feature_block feature_csv_activation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, May 20, 08:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, May 20, 08:48
Fabien requested review of this revision.Wed, May 20, 08:48
teamcity edited the summary of this revision. (Show Details)Wed, May 20, 08:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Wed, May 20, 11:42
deadalnix added a subscriber: deadalnix.

I think there are naked calls to sync_block remaining. Can you fix this first?

The command in the description were fubared, I had to fix them. Did you run them?

This revision now requires changes to proceed.Wed, May 20, 11:42
deadalnix accepted this revision.Wed, May 20, 11:51

It's done in D6153, nevermind.

This revision is now accepted and ready to land.Wed, May 20, 11:51
This revision was automatically updated to reflect the committed changes.