Page MenuHomePhabricator
Differential D6154

net: Use mockable time for tx download
ClosedPublic
Actions

Authored by Fabien on May 20 2020, 10:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGfc9835f6aec3: net: Use mockable time for tx download
rABCfc9835f6aec3: net: Use mockable time for tx download
Summary
Two commits:

  - First commit changes to mockable time for tx download (refactoring,
should only have an effect on regtest)
  - Second commit adds a test that uses mocktime to test tx download

Backport of core PR16197.

Depends on D6146 and D6152.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 20 2020, 10:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 10:04
Fabien requested review of this revision.May 20 2020, 10:04
teamcity edited the summary of this revision. (Show Details)May 20 2020, 10:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 10:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 10:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 10:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 10:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 10:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 10:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10879: Diff 20323.May 20 2020, 10:18
deadalnix accepted this revision.May 20 2020, 11:50
This revision is now accepted and ready to land.May 20 2020, 11:50
Closed by commit rABCfc9835f6aec3: net: Use mockable time for tx download (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyMay 20 2020, 12:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfc9835f6aec3: net: Use mockable time for tx download.
Fabien added a commit: rSTAGINGfc9835f6aec3: net: Use mockable time for tx download.

Revision Contents
Changeset List

PathSize
src/
86 lines
3 lines
5 lines
test/
functional/
189 lines

Diff 20335

View Options

src/net_processing.cpp

Loading...
View Options

src/random.h

Loading...
View Options

src/random.cpp

Loading...
View Options

test/functional/p2p_tx_download.py

Loading...