Differential D617

Check NULLDUMMY after Nov, 13
AbandonedPublic
Actions

Authored by schancel on Oct 18 2017, 23:19.

Tags

None

Subscribers

Details

Reviewers

freetrader
deadalnix

Group Reviewers

Restricted Project

Summary

As per title. This remove soem stupid games one can play.

Test Plan

make check
../qa/pull-tester/rpc-test.py -extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

nulldummy

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1012
Build 1012: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 18 2017, 23:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 18 2017, 23:19

Harbormaster completed remote builds in B1012: Diff 1587.Oct 18 2017, 23:19

schancel accepted this revision.Oct 20 2017, 04:16

schancel added inline comments.

qa/pull-tester/rpc-tests.py
155	Why do we no longer want the test? I see that the test is probably invalid, but don't we want some test of non-NULLDUMMY tx being rejected?
src/validation.cpp
1841	This changes the behavior of OP_CHECKMULTISIGVERIFY so that the requisite, but unused, first element is required to be empty array? This is to remove a way to malleate a transaction?

This revision is now accepted and ready to land.Oct 20 2017, 04:16

Nice to see this. Can there be a Consensus tag for changes like this, that affect network consensus?

sickpig mentioned this in D629: Update version for 0.16.0 release.Oct 30 2017, 20:47

deadalnix planned changes to this revision.Nov 6 2017, 13:42

Unknown Object (User) added a subscriber: Unknown Object (User).Nov 8 2017, 06:23

schancel commandeered this revision.Feb 24 2018, 07:46

schancel abandoned this revision.

schancel edited reviewers, added: deadalnix; removed: schancel.

Revision Contents
Changeset List

Path

Size

qa/

pull-tester/

1 line

rpc-tests/

src/

1 line

Diff 1587

qa/pull-tester/rpc-tests.py

Loading...

qa/rpc-tests/nulldummy.py

Loading...

src/validation.cpp

Loading...