Page MenuHomePhabricator
Differential D6173

Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled
ClosedPublic
Actions

Authored by tobias_ruck on May 20 2020, 18:56.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING76700c0e5e59: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled
rABC76700c0e5e59: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled
Summary

Activation logic is now unnecessary, assuming this code doesn't travel back in time.
This change removes the scriptflag SCRIPT_ENABLE_OP_REVERSEBYTES and all the places it gets activated.
Also entirely removes the activation tests.

Test Plan

ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.May 20 2020, 18:56
Owners added a reviewer: Restricted Owners Package.May 20 2020, 18:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 18:56
tobias_ruck requested review of this revision.May 20 2020, 18:56
teamcity added a comment.May 20 2020, 19:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 19:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 19:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 19:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 19:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 19:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10906: Diff 20381.May 20 2020, 19:17
jasonbcox accepted this revision.May 20 2020, 21:26
jasonbcox added a subscriber: jasonbcox.

Thanks for cleaning this up :)

This revision is now accepted and ready to land.May 20 2020, 21:26
Closed by commit rABC76700c0e5e59: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled (authored by tobias_ruck). · Explain WhyMay 20 2020, 21:34
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC76700c0e5e59: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled.
tobias_ruck added a commit: rSTAGING76700c0e5e59: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled.

Revision Contents
Changeset List

Diff 20390

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script_flags.h

Loading...
View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/op_reversebytes_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/scriptflags.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-op-reversebytes-activation.py

Loading...