Page MenuHomePhabricator
Differential D6174

[backport#16106] gui: Sort wallets in open wallet menu
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 19:24.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC40eb5c46bf73: [backport#16106] gui: Sort wallets in open wallet menu
Summary

https://github.com/bitcoin/bitcoin/pull/16106/commits/224eb9534a8d2b0f140ecb0cc00c61af8ba1da4e

Depends on D6172

Partial backport of Core PR16106

Test Plan
ninja check
./src/qt/bitcoin-qt -regtest -server
./src/bitcoin-cli -regtest createwallet walletA
./src/bitcoin-cli -regtest createwallet walletB
./src/bitcoin-cli -regtest createwallet walletC

see that all wallets are sorted in 'Open wallet'

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 20 2020, 19:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 19:24
majcosta requested review of this revision.May 20 2020, 19:24
teamcity edited the summary of this revision. (Show Details)May 20 2020, 19:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 19:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 19:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 19:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

majcosta added a child revision: D6175: [backport#16106] refactor: Rename getWallets to getOpenWallets in WalletController.May 20 2020, 19:26
teamcity added a comment.May 20 2020, 19:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 19:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 19:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10908: Diff 20383.May 20 2020, 19:37
jasonbcox accepted this revision.May 20 2020, 21:43
This revision is now accepted and ready to land.May 20 2020, 21:43
Closed by commit rABC40eb5c46bf73: [backport#16106] gui: Sort wallets in open wallet menu (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 21 2020, 00:46
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC40eb5c46bf73: [backport#16106] gui: Sort wallets in open wallet menu.

Revision Contents
Changeset List

PathSize
src/
qt/
13 lines
7 lines
12 lines

Diff 20423

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/walletcontroller.h

Loading...
View Options

src/qt/walletcontroller.cpp

Loading...