Page MenuHomePhabricator
Differential D6183

[backport#16348] qt: Assert QMetaObject::invokeMethod result
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 22:36.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC05693cef8445: [backport#16348] qt: Assert QMetaObject::invokeMethod result
Summary

https://github.com/bitcoin/bitcoin/pull/16348/commits/64fee489448c62319e77941c30152084695b5a5d

Depends on D6181

Concludes backport of Core PR16348

Test Plan
ninja check
./src/qt/bitcoin-qt -regtest

Move around UI make sure everything works

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 20 2020, 22:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 22:36
majcosta requested review of this revision.May 20 2020, 22:36
teamcity edited the summary of this revision. (Show Details)May 20 2020, 22:37

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 22:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 22:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 22:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 22:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 22:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

majcosta added a child revision: D6184: [backport#16349] Remove redundant WalletController::addWallet slot.May 20 2020, 22:45
Harbormaster completed remote builds in B10918: Diff 20399.May 20 2020, 22:48
teamcity added a comment.May 20 2020, 22:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

jasonbcox accepted this revision.May 20 2020, 22:51
This revision is now accepted and ready to land.May 20 2020, 22:51
Closed by commit rABC05693cef8445: [backport#16348] qt: Assert QMetaObject::invokeMethod result (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 21 2020, 01:07
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC05693cef8445: [backport#16348] qt: Assert QMetaObject::invokeMethod result.

Revision Contents
Changeset List

Diff 20429

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/qt/splashscreen.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/qt/transactiontablemodel.cpp

Loading...
View Options

src/qt/walletcontroller.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...