Page MenuHomePhabricator
Differential D6175

[backport#16106] refactor: Rename getWallets to getOpenWallets in WalletController
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 19:26.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCae5f71c81884: [backport#16106] refactor: Rename getWallets to getOpenWallets in…
Summary

https://github.com/bitcoin/bitcoin/pull/16106/commits/fa90fe6440301edba71a6f0b1ba3ef1c78d5eae4

Depends on D6174

Completes backport of Core PR16106

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 20 2020, 19:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 19:26
majcosta requested review of this revision.May 20 2020, 19:26
teamcity edited the summary of this revision. (Show Details)May 20 2020, 19:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 19:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 19:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 19:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 19:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 19:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 19:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10909: Diff 20384.May 20 2020, 19:40
majcosta added a child revision: D6177: [backport#15462] gui: Fix async open wallet call order.May 20 2020, 20:00
jasonbcox accepted this revision.May 20 2020, 22:52
This revision is now accepted and ready to land.May 20 2020, 22:52
Closed by commit rABCae5f71c81884: [backport#16106] refactor: Rename getWallets to getOpenWallets in… (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 21 2020, 00:46
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCae5f71c81884: [backport#16106] refactor: Rename getWallets to getOpenWallets in….

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
3 lines
2 lines

Diff 20424

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/walletcontroller.h

Loading...
View Options

src/qt/walletcontroller.cpp

Loading...