Page MenuHomePhabricator
Differential D618

Fix CTxMemPool::ApplyDeltas to accept a reference
ClosedPublic
Actions

Authored by schancel on Oct 19 2017, 00:22.

Details

Reviewers
deadalnix
freetrader
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rSTAGINGd3fd9708d63e: Fix CTxMemPool::ApplyDeltas to accept a reference
rABCd3fd9708d63e: Fix CTxMemPool::ApplyDeltas to accept a reference
Summary

Changes CTxMemPool::ApplyDeltas to properly accept a reference
for nFeeDelta. This parameter was intended to be a returned
value. It was mistakenly changed as a larger refactor.

Fixes T109

Test Plan

make VERBOSE=1 check && qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Oct 19 2017, 00:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2017, 00:22
schancel edited the summary of this revision. (Show Details)Oct 19 2017, 00:23
schancel added a task: Restricted Maniphest Task.
deadalnix accepted this revision.Oct 19 2017, 00:24
This revision is now accepted and ready to land.Oct 19 2017, 00:24
Closed by commit rABCd3fd9708d63e: Fix CTxMemPool::ApplyDeltas to accept a reference (authored by schancel, committed by schancel). · Explain WhyOct 19 2017, 00:29
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
2 lines
2 lines

Diff 1589

View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.cpp

Loading...