Page MenuHomePhabricator
Differential D6283

[seeder] Request headers from new connections
ClosedPublic
Actions

Authored by jasonbcox on May 28 2020, 19:30.

Details

Reviewers
deadalnix
Fabien
nakihito
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC8099bc1028b2: [seeder] Request headers from new connections
Summary

The next step is to use the response to verify the connected node is (probably) on
the right chain using the latest checkpoint.

Depends on D6357

Test Plan
ninja check-seeder

Diff Detail

Event Timeline

nakihito created this revision.May 28 2020, 19:30
Owners added a reviewer: Restricted Owners Package.May 28 2020, 19:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 19:30
nakihito requested review of this revision.May 28 2020, 19:30
nakihito planned changes to this revision.
teamcity added a comment.May 28 2020, 19:31

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 28 2020, 19:31

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 28 2020, 19:31

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 28 2020, 19:32

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 28 2020, 19:37

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Harbormaster completed remote builds in B11070: Diff 20679.May 28 2020, 19:40
teamcity added a comment.May 28 2020, 19:40

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

nakihito mentioned this in D5380: [seeder] Require good seeds to have latest checkpoint.May 28 2020, 21:37
nakihito added reviewers: deadalnix, jasonbcox.May 28 2020, 21:48
nakihito added a child revision: D5380: [seeder] Require good seeds to have latest checkpoint.May 28 2020, 21:56
nakihito requested review of this revision.May 29 2020, 01:43
Fabien requested changes to this revision.Jun 1 2020, 07:13
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/seeder/bitcoin.cpp
182 ↗(On Diff #20679)

As far as I can tell this is the only line that differentiate this block from the above one. Please wrap this into a function to avoid copy and paste.

This revision now requires changes to proceed.Jun 1 2020, 07:13
nakihito updated this revision to Diff 20762.Jun 1 2020, 17:36

Added function.

teamcity added a comment.Jun 1 2020, 17:37

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.Jun 1 2020, 17:37

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.Jun 1 2020, 17:37

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 1 2020, 17:38

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.Jun 1 2020, 17:40

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.Jun 1 2020, 17:47

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11121: Diff 20762.Jun 1 2020, 17:48
deadalnix requested changes to this revision.Jun 1 2020, 23:03

The trigger for getheaders call doesn't not make a lot of sense.

src/seeder/bitcoin.cpp
104 ↗(On Diff #20762)

This only uses vSend from the object, so that a good tell it doesn't really belong as a member function.

177 ↗(On Diff #20762)

It does not make sense to respond a an addr request by a getheaders request.

This revision now requires changes to proceed.Jun 1 2020, 23:03
nakihito planned changes to this revision.Jun 2 2020, 18:59
nakihito updated this revision to Diff 20969.Jun 5 2020, 22:59

Rebased off D6357. Adjusted trigger for GETHEADERS message to occur with GETADDR.

nakihito planned changes to this revision.Jun 5 2020, 22:59
Harbormaster completed remote builds in B11243: Diff 20969.Jun 5 2020, 23:10
nakihito updated this revision to Diff 20975.Jun 6 2020, 00:27

Make use of CBlockLocator class.

nakihito planned changes to this revision.Jun 6 2020, 00:27
Harbormaster completed remote builds in B11249: Diff 20975.Jun 6 2020, 00:38
nakihito requested review of this revision.Jun 6 2020, 00:41
nakihito edited the summary of this revision. (Show Details)Jun 9 2020, 18:58
nakihito added a parent revision: D6357: Dedup net message writing code in the seeder.
Fabien requested changes to this revision.Jun 15 2020, 08:50

Clearing my queue for now, this is subject to changes depending on D6357

src/seeder/bitcoin.cpp
9 ↗(On Diff #20975)

You also need to #include <primitives/blockhash.h> and chainparams.h

This revision now requires changes to proceed.Jun 15 2020, 08:50
nakihito updated this revision to Diff 21612.Jun 22 2020, 22:55

Added includes for primitives/blockhash.h and chainparams.h.

nakihito planned changes to this revision.Jun 22 2020, 22:55
Harbormaster completed remote builds in B11617: Diff 21612.Jun 22 2020, 23:10
jasonbcox commandeered this revision.Dec 10 2020, 23:04
jasonbcox edited reviewers, added: nakihito; removed: jasonbcox.
jasonbcox updated this revision to Diff 26316.Dec 10 2020, 23:05

Rebase and add some basic test coverage

jasonbcox retitled this revision from Seeder sends GETHEADERS message to [seeder] Request headers from new connections.Dec 10 2020, 23:06
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B14378: Diff 26316.Dec 10 2020, 23:18
deadalnix accepted this revision.Dec 11 2020, 17:25
Fabien accepted this revision.Dec 11 2020, 22:27
This revision is now accepted and ready to land.Dec 11 2020, 22:27
Closed by commit rABC8099bc1028b2: [seeder] Request headers from new connections (authored by jasonbcox). · Explain WhyDec 12 2020, 00:00
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC8099bc1028b2: [seeder] Request headers from new connections.

Revision Contents
Changeset List

PathSize
src/
seeder/
6 lines
test/
16 lines

Diff 26316

View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/seeder/test/p2p_messaging_tests.cpp

Loading...