Page MenuHomePhabricator
Differential D6303

Wrap nChainTx into GetChainTxCount
ClosedPublic
Actions

Authored by deadalnix on May 29 2020, 23:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd53cd5450f36: Wrap nChainTx into GetChainTxCount
Summary

This ensure that we can change the layout underneath while keeping the same API.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 29 2020, 23:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2020, 23:00
deadalnix requested review of this revision.May 29 2020, 23:00
teamcity added a comment.May 29 2020, 23:01

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 29 2020, 23:02

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 29 2020, 23:04

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 29 2020, 23:04

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 29 2020, 23:06

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 29 2020, 23:16

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11098: Diff 20725.May 29 2020, 23:16
majcosta added a subscriber: majcosta.May 29 2020, 23:51
majcosta added inline comments.
src/validation.cpp
2056 ↗(On Diff #20725)

does tx=%lu need a fancy macro now that it's a uint64_t? I'm not sure

deadalnix updated this revision to Diff 20726.May 30 2020, 00:02

Also update getchaintxstats

teamcity added a comment.May 30 2020, 00:03

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 30 2020, 00:03

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 30 2020, 00:03

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 30 2020, 00:05

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 30 2020, 00:07

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 30 2020, 00:14

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11099: Diff 20726.May 30 2020, 00:14
deadalnix added a child revision: D6308: Make nChainTx private, ass facility to update it.Jun 1 2020, 01:39
Fabien requested changes to this revision.Jun 1 2020, 06:56
Fabien added a subscriber: Fabien.

There is also a comment in blockvalidity.h that you might want to update if your intent is to remove or rename nChainTx.

src/rpc/blockchain.cpp
2008 ↗(On Diff #20726)

You missed this one

src/validation.cpp
2056 ↗(On Diff #20726)

Marco is right, you can update to: tx=%ld

This revision now requires changes to proceed.Jun 1 2020, 06:56
deadalnix updated this revision to Diff 20740.Jun 1 2020, 12:10

Address feedback

teamcity added a comment.Jun 1 2020, 12:10

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.Jun 1 2020, 12:10

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 1 2020, 12:10

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.Jun 1 2020, 12:13

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.Jun 1 2020, 12:16

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.Jun 1 2020, 12:21

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11111: Diff 20740.Jun 1 2020, 12:21
Fabien accepted this revision.Jun 1 2020, 12:43
This revision is now accepted and ready to land.Jun 1 2020, 12:43
Closed by commit rABCd53cd5450f36: Wrap nChainTx into GetChainTxCount (authored by deadalnix). · Explain WhyJun 1 2020, 12:44
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCd53cd5450f36: Wrap nChainTx into GetChainTxCount.

Revision Contents
Changeset List

PathSize
src/
7 lines
rpc/
6 lines
19 lines

Diff 20742

View Options

src/chain.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.cpp

Loading...