Page MenuHomePhabricator

Wrap nChainTx into GetChainTxCount
ClosedPublic

Authored by deadalnix on May 29 2020, 23:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd53cd5450f36: Wrap nChainTx into GetChainTxCount
Summary

This ensure that we can change the layout underneath while keeping the same API.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta added inline comments.
src/validation.cpp
2056 ↗(On Diff #20725)

does tx=%lu need a fancy macro now that it's a uint64_t? I'm not sure

Also update getchaintxstats

Fabien requested changes to this revision.Jun 1 2020, 06:56
Fabien added a subscriber: Fabien.

There is also a comment in blockvalidity.h that you might want to update if your intent is to remove or rename nChainTx.

src/rpc/blockchain.cpp
2008 ↗(On Diff #20726)

You missed this one

src/validation.cpp
2056 ↗(On Diff #20726)

Marco is right, you can update to: tx=%ld

This revision now requires changes to proceed.Jun 1 2020, 06:56
This revision is now accepted and ready to land.Jun 1 2020, 12:43
This revision was automatically updated to reflect the committed changes.