Page MenuHomePhabricator
Differential D6308

Make nChainTx private, ass facility to update it
ClosedPublic
Actions

Authored by deadalnix on Jun 1 2020, 01:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8a6a51a3d6d7: Make nChainTx private, ass facility to update it
Summary

As per title. This ensures we do not depend on implementation specifics.

Depends on D6303

Test Plan
ninja all check-all

Started a node and stopped it after letting it run for a while a few times to ensure indexing still works as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 1 2020, 01:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 1 2020, 01:24
deadalnix requested review of this revision.Jun 1 2020, 01:24
teamcity added a comment.Jun 1 2020, 01:25

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.Jun 1 2020, 01:25

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.Jun 1 2020, 01:25

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 1 2020, 01:26

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.Jun 1 2020, 01:27

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.Jun 1 2020, 01:34

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11109: Diff 20738.Jun 1 2020, 01:34
deadalnix edited the summary of this revision. (Show Details)Jun 1 2020, 01:39
deadalnix added a parent revision: D6303: Wrap nChainTx into GetChainTxCount.
Fabien accepted this revision.Jun 1 2020, 07:06
This revision is now accepted and ready to land.Jun 1 2020, 07:06
deadalnix updated this revision to Diff 20741.Jun 1 2020, 12:38

rebase

teamcity added a comment.Jun 1 2020, 12:38

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.Jun 1 2020, 12:38

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.Jun 1 2020, 12:38

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 1 2020, 12:40

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.Jun 1 2020, 12:43

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

This revision was landed with ongoing or failed builds.Jun 1 2020, 12:48
Closed by commit rABC8a6a51a3d6d7: Make nChainTx private, ass facility to update it (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC8a6a51a3d6d7: Make nChainTx private, ass facility to update it.
teamcity added a comment.Jun 1 2020, 12:49

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11112: Diff 20741.Jun 1 2020, 12:49
PiRK mentioned this in D12280: validation: have LoadBlockIndex account for snapshot use.Oct 20 2022, 08:07
PiRK mentioned this in rABC95e826419ec1: validation: have LoadBlockIndex account for snapshot use.Oct 24 2022, 12:58

Revision Contents
Changeset List

PathSize
src/
7 lines
18 lines
18 lines

Diff 20743

View Options

src/chain.h

Loading...
View Options

src/chain.cpp

Loading...
View Options

src/validation.cpp

Loading...