Page MenuHomePhabricator
Differential D6384

[backport#18247] test: Wait for both veracks in add_p2p_connection
ClosedPublic
Actions

Authored by majcosta on Jun 5 2020, 16:30.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rABCadcc2330476f: [backport#18247] test: Wait for both veracks in add_p2p_connection
Summary

Partial backport of Core PR18247

Depends on D6431

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 5 2020, 16:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 16:30
majcosta requested review of this revision.Jun 5 2020, 16:30
teamcity edited the summary of this revision. (Show Details)Jun 5 2020, 16:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta updated this revision to Diff 20941.Jun 5 2020, 16:33

added the rest of the PR's changes, just one removed line

majcosta edited the summary of this revision. (Show Details)Jun 5 2020, 16:33
Harbormaster completed remote builds in B11224: Diff 20940.Jun 5 2020, 16:41
Harbormaster completed remote builds in B11225: Diff 20941.Jun 5 2020, 16:43
jasonbcox requested changes to this revision.Jun 5 2020, 17:57
jasonbcox added a subscriber: jasonbcox.

Missing backport of p2p_dos_header_tree.py

This revision now requires changes to proceed.Jun 5 2020, 17:57
majcosta updated this revision to Diff 21035.Jun 7 2020, 02:34

rebase onto proper deps

majcosta added a child revision: D6432: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection.Jun 7 2020, 02:46
Harbormaster completed remote builds in B11286: Diff 21035.Jun 7 2020, 02:46
deadalnix requested changes to this revision.Jun 7 2020, 13:27
deadalnix added a subscriber: deadalnix.

Still missing the dos header tree.

This revision now requires changes to proceed.Jun 7 2020, 13:27
majcosta edited the summary of this revision. (Show Details)Jun 7 2020, 18:54
majcosta added a parent revision: D6431: [backport#16551] test: Test that low difficulty chain fork is rejected.
majcosta requested review of this revision.Jun 7 2020, 18:56
majcosta edited the summary of this revision. (Show Details)

sorry there, my summary was misleading

deadalnix accepted this revision.Jun 7 2020, 20:53
jasonbcox accepted this revision.Jun 8 2020, 17:00
This revision is now accepted and ready to land.Jun 8 2020, 17:00
Closed by commit rABCadcc2330476f: [backport#18247] test: Wait for both veracks in add_p2p_connection (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 8 2020, 17:13
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCadcc2330476f: [backport#18247] test: Wait for both veracks in add_p2p_connection.

Revision Contents
Changeset List

PathSize
test/
functional/
6 lines
7 lines
test_framework/
13 lines

Diff 21096

View Options

test/functional/p2p_leak.py

Loading...
View Options

test/functional/p2p_timeouts.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...