[backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection
ClosedPublic
Actions

Authored by majcosta on Jun 7 2020, 02:46.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rABC9df59f0e695c: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection

Summary

Also replace the two-line (send_message + sync_with_ping) with the one-line send_and_ping

https://github.com/bitcoin/bitcoin/pull/18247/commits/faf1d047313e71658fb31f6b94fdd5d37705ab85

Depends on D6384

Concludes backport of Core PR18247

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 7 2020, 02:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 02:46

majcosta requested review of this revision.Jun 7 2020, 02:46

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11287: Diff 21036.Jun 7 2020, 02:56

deadalnix accepted this revision.Jun 7 2020, 13:27

This revision is now accepted and ready to land.Jun 7 2020, 13:27

jasonbcox accepted this revision.Jun 8 2020, 16:58

Closed by commit rABC9df59f0e695c: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 8 2020, 17:14

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC9df59f0e695c: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection.

PiRK mentioned this in D7545: [Backport]test: replace (send_message + sync_with_ping) with send_and_ping.Sep 24 2020, 07:24

PiRK mentioned this in rABCc27d58dec9fa: [Backport]test: replace (send_message + sync_with_ping) with send_and_ping.Sep 24 2020, 09:29

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_dos_header_tree.py

9 lines

p2p_invalid_messages.py

1 line

Diff 21097

View Options

test/functional/p2p_dos_header_tree.py