Differential D6403

[backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated types
ClosedPublic
Actions

Authored by majcosta on Jun 6 2020, 10:42.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCf8e75cb4a84a: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated…

Summary

https://github.com/bitcoin/bitcoin/pull/15452/commits/70946e7fee54323ce6a5ea8aeb377e2c7c790bc6

Depends on D6402

Partial backport of Core PR15452

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11252
Build 21247: Default Diff Build & Tests
Build 21246: Build without Wallet
Build 21245: Build with clang-10
Build 21244: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 6 2020, 10:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 10:42

majcosta requested review of this revision.Jun 6 2020, 10:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6404: [backport#15452] GetKeyBirthTimes should return key ids, not destinations.Jun 6 2020, 10:44

deadalnix accepted this revision.Jun 6 2020, 10:48

This revision is now accepted and ready to land.Jun 6 2020, 10:48

Harbormaster completed remote builds in B11252: Diff 20980.Jun 6 2020, 11:02

Closed by commit rABCf8e75cb4a84a: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated… (authored by Gregory Sanders <gsanders87@gmail.com>, committed by majcosta). · Explain WhyJun 6 2020, 11:09

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCf8e75cb4a84a: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated….

Revision Contents
Changeset List

Path

Size

src/

bench/

4 lines

6 lines

8 lines

8 lines

4 lines

7 lines

qt/

coincontroldialog.cpp

4 lines

guiutil.cpp

2 lines

signverifymessagedialog.cpp

10 lines

test/

wallettests.cpp

4 lines

rpc/

misc.cpp

6 lines

rawtransaction.cpp

2 lines

util.cpp

4 lines

script/

descriptor.cpp

6 lines

standard.h

20 lines

standard.cpp

17 lines

test/

blockfilter_index_tests.cpp

2 lines

cashaddrenc_tests.cpp

20 lines

coins_tests.cpp

4 lines

denialofservice_tests.cpp

6 lines

dstencode_tests.cpp

4 lines

key_tests.cpp

8 lines

miner_tests.cpp

2 lines

script_p2sh_tests.cpp

26 lines

script_standard_tests.cpp

56 lines

script_tests.cpp

4 lines

transaction_tests.cpp

18 lines

txindex_tests.cpp

2 lines

txvalidationcache_tests.cpp

4 lines

wallet/

rpcdump.cpp

14 lines

rpcwallet.cpp

16 lines

test/

wallet_tests.cpp

8 lines

walletdb_tests.cpp

12 lines

wallet.cpp

10 lines

Diff 20980

View Options

src/bench/ccoins_caching.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/cashaddrenc.cpp

View Options

src/key_io.cpp

View Options

src/keystore.cpp

View Options

src/outputtype.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/signverifymessagedialog.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/util.cpp

View Options

src/script/descriptor.cpp

View Options

src/script/standard.h

View Options

src/script/standard.cpp

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/cashaddrenc_tests.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/dstencode_tests.cpp

View Options

src/test/key_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

View Options

src/test/script_standard_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/txindex_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/test/walletdb_tests.cpp

View Options

[backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated typesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20980

src/bench/ccoins_caching.cpp

src/bitcoin-tx.cpp

src/cashaddrenc.cpp

src/key_io.cpp

src/keystore.cpp

src/outputtype.cpp

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/signverifymessagedialog.cpp

src/qt/test/wallettests.cpp

src/rpc/misc.cpp

src/rpc/rawtransaction.cpp

src/rpc/util.cpp

src/script/descriptor.cpp

src/script/standard.h

src/script/standard.cpp

src/test/blockfilter_index_tests.cpp

src/test/cashaddrenc_tests.cpp

src/test/coins_tests.cpp

src/test/denialofservice_tests.cpp

src/test/dstencode_tests.cpp

src/test/key_tests.cpp

src/test/miner_tests.cpp

src/test/script_p2sh_tests.cpp

src/test/script_standard_tests.cpp

src/test/script_tests.cpp

src/test/transaction_tests.cpp

src/test/txindex_tests.cpp

src/test/txvalidationcache_tests.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/wallet_tests.cpp

src/wallet/test/walletdb_tests.cpp

src/wallet/wallet.cpp

[backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated types
ClosedPublic
Actions

Revision Contents
Changeset List