[backport#13756] Wallet/rpc: add 'avoid_reuse' option to RPC commands
ClosedPublic
Actions

Authored by majcosta on Jun 8 2020, 21:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

createwallet, getbalance, getwalletinfo, listunspent, sendtoaddress

rpc/wallet: listunspent include reused flag and show reused utxos by default

Depends on D6464

Partial backport of Core PR13756

Test Plan

ninja check
./src/bitcoind/bitcoind -daemon -regtest

run bitcoin-cli help for the commands above check if everything is in order

the proper functional test for this feature is in the next commit D6466

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

majcosta requested review of this revision.Jun 8 2020, 21:29

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta edited the test plan for this revision. (Show Details)Jun 8 2020, 21:33

Fabien requested changes to this revision.Jun 9 2020, 07:21

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/wallet/rpcwallet.cpp
44 ↗	(On Diff #21118)
3388 ↗	(On Diff #21118)	?
3439 ↗	(On Diff #21118)	There was no problem with the previous layout, you might have something wrong in your config somewhere
3464 ↗	(On Diff #21118)	Dito, even if this one is not a big deal