Page MenuHomePhabricator
Differential D6463

[backport#13756] wallet: enable avoid_reuse feature
ClosedPublic
Actions

Authored by majcosta on Jun 8 2020, 21:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC162108998db7: [backport#13756] wallet: enable avoid_reuse feature
Summary

https://github.com/bitcoin/bitcoin/pull/13756/commits/8247a0da3a46d7c38943ee0304343ab7465305bd

Partial backport of Core PR13756

Test Plan
ninja check

the proper functional test for this feature is included in a posterior commit D6466

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 8 2020, 21:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 21:17
majcosta requested review of this revision.Jun 8 2020, 21:17
teamcity edited the summary of this revision. (Show Details)Jun 8 2020, 21:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6464: [backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS.Jun 8 2020, 21:23
Harbormaster completed remote builds in B11332: Diff 21116.Jun 8 2020, 21:27
majcosta edited the test plan for this revision. (Show Details)Jun 8 2020, 21:33
Fabien requested changes to this revision.Jun 9 2020, 07:00
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
1121 ↗(On Diff #21116)

Move the comment on its line

src/wallet/wallet.h
1064 ↗(On Diff #21116)

Nit: TxId &hash => TxId &txid
This makes it more consistent with other parts of the code

This revision now requires changes to proceed.Jun 9 2020, 07:00
majcosta updated this revision to Diff 21141.Jun 9 2020, 15:04

addressed comments and nits

Harbormaster completed remote builds in B11352: Diff 21141.Jun 9 2020, 15:14
Fabien accepted this revision.Jun 9 2020, 17:39
This revision is now accepted and ready to land.Jun 9 2020, 17:39
Closed by commit rABC162108998db7: [backport#13756] wallet: enable avoid_reuse feature (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by majcosta). · Explain WhyJun 9 2020, 17:55
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC162108998db7: [backport#13756] wallet: enable avoid_reuse feature.

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
8 lines
85 lines

Diff 21158

View Options

src/wallet/ismine.h

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...