Page MenuHomePhabricator

[backport#13756] wallet: enable avoid_reuse feature
ClosedPublic

Authored by majcosta on Jun 8 2020, 21:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC162108998db7: [backport#13756] wallet: enable avoid_reuse feature
Summary
Test Plan
ninja check

the proper functional test for this feature is included in a posterior commit D6466

Event Timeline

majcosta requested review of this revision.Jun 8 2020, 21:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Jun 9 2020, 07:00
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
1121 ↗(On Diff #21116)

Move the comment on its line

src/wallet/wallet.h
1064 ↗(On Diff #21116)

Nit: TxId &hash => TxId &txid
This makes it more consistent with other parts of the code

This revision now requires changes to proceed.Jun 9 2020, 07:00

addressed comments and nits

This revision is now accepted and ready to land.Jun 9 2020, 17:39