Page MenuHomePhabricator
Differential D6464

[backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS
ClosedPublic
Actions

Authored by majcosta on Jun 8 2020, 21:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3f601d7850a5: [backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS
Summary

https://github.com/bitcoin/bitcoin/pull/13756/commits/f904723e0d5883309cb0dd14b826bc45c5e776fb

Depends on D6463

Partial backport of Core PR13756

Test Plan
ninja check

the proper functional test for this feature is included in a posterior commit D6466

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 8 2020, 21:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 21:23
majcosta requested review of this revision.Jun 8 2020, 21:23
teamcity edited the summary of this revision. (Show Details)Jun 8 2020, 21:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6465: [backport#13756] Wallet/rpc: add 'avoid_reuse' option to RPC commands.Jun 8 2020, 21:29
majcosta edited the test plan for this revision. (Show Details)Jun 8 2020, 21:33
Harbormaster completed remote builds in B11333: Diff 21117.Jun 8 2020, 21:33
Fabien accepted this revision.Jun 9 2020, 07:07
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/rpcwallet.cpp
4865 ↗(On Diff #21117)

Nit: alignment

This revision is now accepted and ready to land.Jun 9 2020, 07:07
Closed by commit rABC3f601d7850a5: [backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by majcosta). · Explain WhyJun 9 2020, 17:56
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC3f601d7850a5: [backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS.

Revision Contents
Changeset List

PathSize
src/
rpc/
1 line
wallet/
81 lines
2 lines

Diff 21159

View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...