Page MenuHomePhabricator

Convert the DNS handling code in the seeder to C++
ClosedPublic

Authored by deadalnix on Nov 8 2017, 11:58.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/seeder/dns.cpp
214 ↗(On Diff #1674)

I thought C++ treated all decls as if they were immediately after the start of the function? Should it be initialized to something here?

Also Prdeclare -> Predeclare

360 ↗(On Diff #1674)

What's the purpose of this block?

410 ↗(On Diff #1674)

Is there a better way to leave debug prints around?

src/seeder/dns.cpp
410 ↗(On Diff #1674)

Yes, using a logging system.

src/seeder/dns.cpp
410 ↗(On Diff #1674)

If you put a task in with an example of how to do it in the seeder, I can clean these up.

This revision is now accepted and ready to land.Nov 8 2017, 16:45
src/seeder/dns.cpp
360 ↗(On Diff #1674)

Scope declarations.

This revision was automatically updated to reflect the committed changes.