Differential D6533

scheduler: switch from boost to std
ClosedPublic
Actions

Authored by deadalnix on Jun 11 2020, 12:03.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1af5e7c22bca: scheduler: switch from boost to std

Summary

Changes from boost::chrono to std::chrono, boost::condition_var to
std::condition_var, boost::mutex to sync.h Mutex, and reverselock.h to
sync.h REVERSE_LOCK. Also adds threadsafety annotations to CScheduler
members.

This is a partial backport of Core PR18234 : https://github.com/bitcoin/bitcoin/pull/18234/commits/d0ebd93270758ea97ea956b8821e17a2d001ea94

Depends on D6532

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18234-3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11422
Build 21848: Default Diff Build & Tests	Link to the build
Build 21847: Build without Wallet	Link to the build
Build 21846: Build with clang-10	Link to the build
Build 21845: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 11 2020, 12:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2020, 12:03

deadalnix requested review of this revision.Jun 11 2020, 12:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D6535: Drop unused reverselock.h.Jun 11 2020, 12:07

Harbormaster completed remote builds in B11422: Diff 21278.Jun 11 2020, 12:17

Fabien accepted this revision.Jun 11 2020, 12:54

This revision is now accepted and ready to land.Jun 11 2020, 12:54

Closed by commit rABC1af5e7c22bca: scheduler: switch from boost to std (authored by Anthony Towns <aj@erisian.com.au>, committed by deadalnix). · Explain WhyJun 11 2020, 13:12

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC1af5e7c22bca: scheduler: switch from boost to std.

Revision Contents
Changeset List

Path

Size

src/

rpc/

2 lines

43 lines

51 lines

test/

avalanche_tests.cpp

4 lines

scheduler_tests.cpp

44 lines

util/

2 lines

test/

lint/

lint-boost-dependencies.sh

1 line

Diff 21278

src/rpc/misc.cpp

Loading...

src/scheduler.h

Loading...

src/scheduler.cpp

Loading...

src/test/avalanche_tests.cpp

Loading...

src/test/scheduler_tests.cpp

Loading...

src/test/util/setup_common.h

Loading...

test/lint/lint-boost-dependencies.sh

Loading...