Merge #15059: test: Add basic test for BIP34
AbandonedPublic
Actions

Authored by nakihito on Jun 15 2020, 21:56.

Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

fab17e8272f5f70213f186809479ee7a75898b1d test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

BIP34 was disabled for testing, which explains why it had no test.

Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f

Backport of Core PR15059

Depends on D6603

Test Plan

ninja
ninja check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15059

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11510
Build 22173: Default Diff Build & Tests	Link to the build
Build 22172: Build without Wallet	Link to the build
Build 22171: Build with clang-10	Link to the build
Build 22170: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 15 2020, 21:56

Owners added a reviewer: Restricted Owners Package.Jun 15 2020, 21:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 21:56

nakihito requested review of this revision.Jun 15 2020, 21:57

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito added inline comments.Jun 15 2020, 21:59

src/chainparams.cpp
510	Note: this must be > 581 due to `abc-miner-fund.py`.
test/functional/abc-miner-fund.py
200	block_height = 581 here which necessitates the divergence in `chainparams.cpp`.

Harbormaster completed remote builds in B11510: Diff 21439.Jun 15 2020, 22:10

jasonbcox requested changes to this revision.Jun 15 2020, 22:43

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/chainparams.cpp
510	Diverging here doesn't make sense. If something is broken with abc-miner-fund, it should be fixed first.
512	functioanl -> functional

This revision now requires changes to proceed.Jun 15 2020, 22:43

Rebased off D6603.

nakihito edited the summary of this revision. (Show Details)Jun 16 2020, 01:46

nakihito added a parent revision: D6603: Use fewer blocks in abc-miner-fund.py.

Harbormaster completed remote builds in B11519: Diff 21452.Jun 16 2020, 01:59

Unfortunately, D6603 appears to be based on erroneous assumption about what the problem is. This turned out to be a blocker for some stuff I'm working on so I backported it in D6679 .

This revision now requires changes to proceed.Jun 23 2020, 14:12

nakihito abandoned this revision.Jun 23 2020, 22:14