Page MenuHomePhabricator
Differential D6655

Merge #18563: test: Fix unregister_all_during_call cleanup
ClosedPublic
Actions

Authored by jasonbcox on Jun 19 2020, 01:26.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC6f74431345ff: Merge #18563: test: Fix unregister_all_during_call cleanup
Summary

13d2a33537a403ac47a989be92109d3214375b6a Fix unregister_all_during_call cleanup (Russell Yanofsky)

Pull request description:

Use `TestingSetup` fixture to fix `unregister_all_during_call` test not calling `UnregisterBackgroundSignalScheduler`, which could trigger an assert in `RegisterBackgroundSignalScheduler` when called in later tests

Failure reported by fanquake https://github.com/bitcoin/bitcoin/pull/18551#issuecomment-610974251

ACKs for top commit:

MarcoFalke:
  ACK 13d2a33537a403ac47a989be92109d3214375b6a if appveyor unit tests pass

Tree-SHA512: d2ec8ff14c54d97903af50031abfac1f38ec1c3aabc90371cfd5b79481fa69d3d77f339bfdf7d2178fd85e83402f72eda7cf4d339e5bbfa7e6e1a68836643b93

Backport of Core PR18563

Depends on D6654

Test Plan

ninja check

Diff Detail

Event Timeline

jasonbcox created this revision.Jun 19 2020, 01:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2020, 01:26
jasonbcox requested review of this revision.Jun 19 2020, 01:26
teamcity edited the summary of this revision. (Show Details)Jun 19 2020, 01:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Jun 19 2020, 01:32
This revision is now accepted and ready to land.Jun 19 2020, 01:32
Harbormaster completed remote builds in B11586: Diff 21562.Jun 19 2020, 01:42
Fabien mentioned this in D6654: Merge #18551: Do not clear validationinterface entries being executed.Jun 19 2020, 07:17
Closed by commit rABC6f74431345ff: Merge #18563: test: Fix unregister_all_during_call cleanup (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyJun 20 2020, 00:43
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC6f74431345ff: Merge #18563: test: Fix unregister_all_during_call cleanup.

Revision Contents
Changeset List

PathSize
src/
test/
7 lines

Diff 21562

View Options

src/test/validationinterface_tests.cpp

Loading...