Page MenuHomePhabricator
Differential D6653

Merge #18524: refactor: drop boost::signals2 in validationinterface
ClosedPublic
Actions

Authored by jasonbcox on Jun 19 2020, 01:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC27fc0488693b: Merge #18524: refactor: drop boost::signals2 in validationinterface
Summary

d6815a2313158862d448733954a73520f223deb6 refactor: drop boost::signals2 in validationinterface (Russell Yanofsky)

Pull request description:

Stop using boost::signals2 internally in validationinterface. Replace with std::list and Add/Remove/Clear/Iterate helper functions.

Motivation for change is to reduce dependencies and avoid issues happening with boost versions before 1.59: https://github.com/bitcoin/bitcoin/issues/18517, https://github.com/bitcoin/bitcoin/pull/18471

ACKs for top commit:

MarcoFalke:
  ACK d6815a2313158862d448733954a73520f223deb6
laanwj:
  ACK d6815a2313158862d448733954a73520f223deb6
hebasto:
  re-ACK d6815a2313158862d448733954a73520f223deb6
promag:
  ACK d6815a2313158862d448733954a73520f223deb6.

Tree-SHA512: 4fc0f14a8446e8616cc142af6c3d36815f3254525d30348ba8e4d4bc74c249a5a8c9bc119bdd1be7ebd7abe0b784bc0c5551a3e156a766890cb2fdd891a95919

Backport of Core PR18524

Depends on D6652

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 19 2020, 01:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2020, 01:04
jasonbcox requested review of this revision.Jun 19 2020, 01:04
teamcity edited the summary of this revision. (Show Details)Jun 19 2020, 01:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox added a child revision: D6654: Merge #18551: Do not clear validationinterface entries being executed.Jun 19 2020, 01:24
Harbormaster completed remote builds in B11584: Diff 21560.Jun 19 2020, 01:26
Fabien accepted this revision.Jun 19 2020, 07:08
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validationinterface.cpp
55 ↗(On Diff #21560)

Braces

64 ↗(On Diff #21560)

Dito

This revision is now accepted and ready to land.Jun 19 2020, 07:08
jasonbcox updated this revision to Diff 21570.Jun 19 2020, 20:24

Fixed braces

Harbormaster completed remote builds in B11593: Diff 21570.Jun 19 2020, 20:39
Closed by commit rABC27fc0488693b: Merge #18524: refactor: drop boost::signals2 in validationinterface (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by deadalnix). · Explain WhyJun 20 2020, 00:28
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC27fc0488693b: Merge #18524: refactor: drop boost::signals2 in validationinterface.
PiRK mentioned this in D8865: [validation interface] Remove vtxConflicted from BlockConnected.Jan 11 2021, 10:35
PiRK mentioned this in rABCf5d5ae637eb0: [validation interface] Remove vtxConflicted from BlockConnected.Jan 11 2021, 14:20

Revision Contents
Changeset List

Diff 21572

View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...