Page MenuHomePhabricator

Merge #18524: refactor: drop boost::signals2 in validationinterface
ClosedPublic

Authored by jasonbcox on Jun 19 2020, 01:04.

Details

Summary

d6815a2313158862d448733954a73520f223deb6 refactor: drop boost::signals2 in validationinterface (Russell Yanofsky)

Pull request description:

Stop using boost::signals2 internally in validationinterface. Replace with std::list and Add/Remove/Clear/Iterate helper functions.

Motivation for change is to reduce dependencies and avoid issues happening with boost versions before 1.59: https://github.com/bitcoin/bitcoin/issues/18517, https://github.com/bitcoin/bitcoin/pull/18471

ACKs for top commit:

MarcoFalke:
  ACK d6815a2313158862d448733954a73520f223deb6
laanwj:
  ACK d6815a2313158862d448733954a73520f223deb6
hebasto:
  re-ACK d6815a2313158862d448733954a73520f223deb6
promag:
  ACK d6815a2313158862d448733954a73520f223deb6.

Tree-SHA512: 4fc0f14a8446e8616cc142af6c3d36815f3254525d30348ba8e4d4bc74c249a5a8c9bc119bdd1be7ebd7abe0b784bc0c5551a3e156a766890cb2fdd891a95919

Backport of Core PR18524

Depends on D6652

Test Plan

ninja check check-functional

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validationinterface.cpp
55

Braces

64

Dito

This revision is now accepted and ready to land.Jun 19 2020, 07:08