Rename Messagestart into DiskMagic and CashMessageStart into NetMagic
ClosedPublic
Actions

Authored by deadalnix on Nov 13 2017, 14:43.

Details

Reviewers

schancel
freetrader

Group Reviewers

Restricted Project

Commits

rSTAGING704f0a7005fa: Rename Messagestart into DiskMagic and CashMessageStart into NetMagic
rABC704f0a7005fa: Rename Messagestart into DiskMagic and CashMessageStart into NetMagic

Summary

It make things clearer.

Test Plan

make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 13 2017, 14:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2017, 14:43

schancel added inline comments.Nov 13 2017, 16:13

src/chainparams.cpp
154 ↗	(On Diff #1715)	Why diskMagic?

schancel accepted this revision.Nov 13 2017, 19:18

This revision is now accepted and ready to land.Nov 13 2017, 19:18

deadalnix added inline comments.Nov 13 2017, 20:33

src/chainparams.cpp
154 ↗	(On Diff #1715)	Because this is the magic used when serializing messages on disk :)

Closed by commit rABC704f0a7005fa: Rename Messagestart into DiskMagic and CashMessageStart into NetMagic (authored by deadalnix). · Explain WhyNov 13 2017, 20:34

This revision was automatically updated to reflect the committed changes.

PiRK mentioned this in D10569: Use disk magic as sqlite wallet application ID.Nov 26 2021, 15:07

Revision Contents
Changeset List

Path

Size

src/

8 lines

12 lines

48 lines

7 lines

2 lines

11 lines

6 lines

test/

net_tests.cpp

2 lines

test_bitcoin_fuzzy.cpp

4 lines

validation_tests.cpp

2 lines

validation.h

4 lines

validation.cpp

16 lines

Diff 1724

View Options

src/addrdb.cpp

View Options

src/chainparams.h

View Options

src/chainparams.cpp

View Options

src/net.h

View Options

src/net_processing.cpp

View Options

src/protocol.h

View Options

src/protocol.cpp

View Options

src/test/net_tests.cpp

View Options

src/test/test_bitcoin_fuzzy.cpp

View Options

src/test/validation_tests.cpp

View Options

src/validation.h

View Options

Rename Messagestart into DiskMagic and CashMessageStart into NetMagicClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1724

src/addrdb.cpp

src/chainparams.h

src/chainparams.cpp

src/net.h

src/net_processing.cpp

src/protocol.h

src/protocol.cpp

src/test/net_tests.cpp

src/test/test_bitcoin_fuzzy.cpp

src/test/validation_tests.cpp

src/validation.h

src/validation.cpp

Rename Messagestart into DiskMagic and CashMessageStart into NetMagic
ClosedPublic
Actions

Revision Contents
Changeset List