Page MenuHomePhabricator

Prepare wallet for explicit Amount construction
ClosedPublic

Authored by schancel on Nov 14 2017, 00:13.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
wallet-cpp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1108
Build 1108: arc lint + arc unit

Event Timeline

Herald added a reviewer: Restricted Project. · View Herald Transcript
deadalnix requested changes to this revision.Nov 14 2017, 14:57
deadalnix added inline comments.
src/wallet/wallet.cpp
2713

typeof(Amount / intergral) == Amount

2720
typeof(Amount % intergral) == Amount
This revision now requires changes to proceed.Nov 14 2017, 14:57
src/wallet/wallet.cpp
2720

We got rid of this operator. Do you want it added back?

src/wallet/wallet.cpp
2720

I think we should granted the right types are used. It seems like it is useful. When you force people to jump through hoops to do something legit, you end up with more errors at the end.

Add modulus operator and use in the wallet.

This revision is now accepted and ready to land.Nov 16 2017, 10:30
This revision was automatically updated to reflect the committed changes.