Page MenuHomePhabricator

refactor: Make scheduler methods type safe
ClosedPublic

Authored by Fabien on Mon, Jun 29, 11:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCed2f9c673fdd: refactor: Make scheduler methods type safe
Summary

Backport of core PR18289.

This diff extends the original PR a bit due to avalanche.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Jun 29, 11:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jun 29, 11:34
Fabien requested review of this revision.Mon, Jun 29, 11:34
teamcity edited the summary of this revision. (Show Details)Mon, Jun 29, 11:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Mon, Jun 29, 11:58
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/scheduler.h
30 ↗(On Diff #21844)

Clearly, this needs to be reformated properly.

This revision now requires changes to proceed.Mon, Jun 29, 11:58
Fabien updated this revision to Diff 21846.Mon, Jun 29, 12:13

Relayout the usage comment

deadalnix accepted this revision.Mon, Jun 29, 12:37
This revision is now accepted and ready to land.Mon, Jun 29, 12:37
This revision was automatically updated to reflect the committed changes.