Page MenuHomePhabricator
Differential D6764

refactor: Make scheduler methods type safe
ClosedPublic
Actions

Authored by Fabien on Jun 29 2020, 11:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCed2f9c673fdd: refactor: Make scheduler methods type safe
Summary

Backport of core PR18289.

This diff extends the original PR a bit due to avalanche.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 29 2020, 11:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2020, 11:34
Fabien requested review of this revision.Jun 29 2020, 11:34
teamcity edited the summary of this revision. (Show Details)Jun 29 2020, 11:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Jun 29 2020, 11:58
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/scheduler.h
30 ↗(On Diff #21844)

Clearly, this needs to be reformated properly.

This revision now requires changes to proceed.Jun 29 2020, 11:58
Harbormaster completed remote builds in B11761: Diff 21844.Jun 29 2020, 12:13
Fabien updated this revision to Diff 21846.Jun 29 2020, 12:13

Relayout the usage comment

Harbormaster completed remote builds in B11763: Diff 21846.Jun 29 2020, 12:34
deadalnix accepted this revision.Jun 29 2020, 12:37
This revision is now accepted and ready to land.Jun 29 2020, 12:37
Closed by commit rABCed2f9c673fdd: refactor: Make scheduler methods type safe (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJun 29 2020, 13:07
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCed2f9c673fdd: refactor: Make scheduler methods type safe.

Revision Contents
Changeset List

PathSize
src/
avalanche/
3 lines
3 lines
3 lines
4 lines
7 lines
6 lines
2 lines
34 lines
24 lines
test/
19 lines
wallet/
4 lines

Diff 21849

View Options

src/avalanche/avalanche.cpp

Loading...
View Options

src/banman.h

Loading...
View Options

src/eventloop.h

Loading...
View Options

src/eventloop.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/scheduler.h

Loading...
View Options

src/scheduler.cpp

Loading...
View Options

src/test/scheduler_tests.cpp

Loading...
View Options

src/wallet/load.cpp

Loading...