Page MenuHomePhabricator

Move NodeContext from TestingSetup to BasicTestingSetup
ClosedPublic

Authored by Fabien on Mon, Jun 29, 14:52.

Details

Summary

This will allow for the scheduler to be destructed even for tests that
only use the BasicTestingSetup. This fixes a TSAN lock order inversion
issue when running the reverselock_tests and the scheduler_tests
together.

Extracted from core PR18571.

Test Plan
./src/test/test_bitcoin -t reverselock_tests,scheduler_tests
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Jun 29, 14:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jun 29, 14:52
Fabien requested review of this revision.Mon, Jun 29, 14:52
teamcity edited the summary of this revision. (Show Details)Mon, Jun 29, 14:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Mon, Jun 29, 14:56
This revision is now accepted and ready to land.Mon, Jun 29, 14:56
jasonbcox accepted this revision.Mon, Jun 29, 15:37
This revision was automatically updated to reflect the committed changes.