Page MenuHomePhabricator

Move NodeContext from TestingSetup to BasicTestingSetup
ClosedPublic

Authored by Fabien on Jun 29 2020, 14:52.

Details

Summary

This will allow for the scheduler to be destructed even for tests that
only use the BasicTestingSetup. This fixes a TSAN lock order inversion
issue when running the reverselock_tests and the scheduler_tests
together.

Extracted from core PR18571.

Test Plan
./src/test/test_bitcoin -t reverselock_tests,scheduler_tests
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jun 29 2020, 14:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jun 29 2020, 14:56