Page MenuHomePhabricator
Differential D6766

Move NodeContext from TestingSetup to BasicTestingSetup
ClosedPublic
Actions

Authored by Fabien on Jun 29 2020, 14:52.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC90aaf20e54cf: Move NodeContext from TestingSetup to BasicTestingSetup
Summary

This will allow for the scheduler to be destructed even for tests that
only use the BasicTestingSetup. This fixes a TSAN lock order inversion
issue when running the reverselock_tests and the scheduler_tests
together.

Extracted from core PR18571.

Test Plan
./src/test/test_bitcoin -t reverselock_tests,scheduler_tests
ninja check

Diff Detail

Event Timeline

Fabien created this revision.Jun 29 2020, 14:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2020, 14:52
Fabien requested review of this revision.Jun 29 2020, 14:52
teamcity edited the summary of this revision. (Show Details)Jun 29 2020, 14:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Jun 29 2020, 14:56
This revision is now accepted and ready to land.Jun 29 2020, 14:56
Harbormaster completed remote builds in B11765: Diff 21851.Jun 29 2020, 15:06
jasonbcox accepted this revision.Jun 29 2020, 15:37
Closed by commit rABC90aaf20e54cf: Move NodeContext from TestingSetup to BasicTestingSetup (authored by Fabien). · Explain WhyJun 29 2020, 15:52
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC90aaf20e54cf: Move NodeContext from TestingSetup to BasicTestingSetup.

Revision Contents
Changeset List

PathSize
src/
test/
util/
2 lines

Diff 21851

View Options

src/test/util/setup_common.h

Loading...