Page MenuHomePhabricator
Differential D678

Prepare more files for explicit Amount constructor
ClosedPublic
Actions

Authored by schancel on Nov 14 2017, 01:32.

Details

Reviewers
deadalnix
freetrader
mbhinder
Group Reviewers
Restricted Project
Commits
rSTAGING5e74d11ac129: Prepare more files for explicit Amount constructor
rABC5e74d11ac129: Prepare more files for explicit Amount constructor
Summary

Continue T104 for:

  • src/policy/fees.cpp
  • src/primitives/transaction.cpp
  • src/primitives/transaction.h
  • src/script/sign.cpp
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
few-changes3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1135
Build 1135: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 14 2017, 01:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 14 2017, 01:32
Harbormaster completed remote builds in B1112: Diff 1731.Nov 14 2017, 01:32
deadalnix requested changes to this revision.Nov 14 2017, 14:51
deadalnix added inline comments.
src/policy/fees.cpp
511 ↗(On Diff #1731)

I think the median should be converted to an amount here.

This revision now requires changes to proceed.Nov 14 2017, 14:51
schancel updated this revision to Diff 1760.Nov 15 2017, 17:59

Convert median to Amount

deadalnix accepted this revision.Nov 15 2017, 18:02
This revision is now accepted and ready to land.Nov 15 2017, 18:02
Closed by commit rABC5e74d11ac129: Prepare more files for explicit Amount constructor (authored by schancel). · Explain WhyNov 15 2017, 22:34
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
policy/
12 lines
primitives/
6 lines
2 lines
script/
4 lines

Diff 1760

View Options

src/policy/fees.cpp

Loading...
View Options

src/primitives/transaction.h

Loading...
View Options

src/primitives/transaction.cpp

Loading...
View Options

src/script/sign.cpp

Loading...