Page MenuHomePhabricator
Differential D6818

[avalanche] Add the notion of Peer to the PeerManager
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2020, 01:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb406ddfc609f: [avalanche] Add the notion of Peer to the PeerManager
Summary

An avalanche Peer can be one or more nodes, so that a large peer can instanciate several nodes to be able to serve more requests.

This allows to rework the compactions algorithm to make it much simpler.

Test Plan
ninja check-avalanche

The update of the verify function should check that the Peer remain in a coherent state.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 4 2020, 01:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2020, 01:00
deadalnix requested review of this revision.Jul 4 2020, 01:00
deadalnix updated this revision to Diff 21993.

vetor => vector

Harbormaster completed remote builds in B11845: Diff 21992.Jul 4 2020, 01:12
Harbormaster completed remote builds in B11846: Diff 21993.Jul 4 2020, 01:19
deadalnix added a child revision: D6822: [avalanche] Add node related functions to the peermanager.Jul 5 2020, 00:31
deadalnix updated this revision to Diff 22004.Jul 5 2020, 00:44

rebase

Harbormaster completed remote builds in B11854: Diff 22004.Jul 5 2020, 01:19
deadalnix planned changes to this revision.Jul 5 2020, 02:41

There is a better way to do this using multi index magic.

deadalnix mentioned this in D6822: [avalanche] Add node related functions to the peermanager.Jul 5 2020, 02:42
deadalnix updated this revision to Diff 22008.Jul 5 2020, 17:25

Simplify the Peer struct so that it doesn't contain nodes. Nodes wills be stored in their own datastructure later on.

Harbormaster completed remote builds in B11857: Diff 22008.Jul 5 2020, 17:38
Fabien accepted this revision.Jul 6 2020, 06:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/peermanager.cpp
54 ↗(On Diff #22008)

Nit: alocation => allocation

This revision is now accepted and ready to land.Jul 6 2020, 06:02
Closed by commit rABCb406ddfc609f: [avalanche] Add the notion of Peer to the PeerManager (authored by deadalnix). · Explain WhyJul 6 2020, 12:36
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb406ddfc609f: [avalanche] Add the notion of Peer to the PeerManager.

Revision Contents
Changeset List

PathSize
src/
avalanche/
13 lines
68 lines

Diff 22015

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...