Differential D6911

[avalanche] Change the addavalanchenode RPC so that it return if the operation succeeded
ClosedPublic
Actions

Authored by deadalnix on Jul 11 2020, 00:20.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCdd13e82f8537: [avalanche] Change the addavalanchenode RPC so that it return if the operation…

Summary

Also rename avalanche::Processor::addPeer into addNode for consistency.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

addavanodereturn

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11977
Build 23765: Default Diff Build & Tests
Build 23764: Build without Wallet	build-without-wallet
Build 23763: Build with clang-10	build-clang-10
Build 23762: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 11 2020, 00:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2020, 00:20

deadalnix requested review of this revision.Jul 11 2020, 00:20

Harbormaster completed remote builds in B11977: Diff 22215.Jul 11 2020, 00:36

majcosta accepted this revision.Jul 11 2020, 02:52

majcosta added a subscriber: majcosta.

majcosta added inline comments.

src/rpc/avalanche.cpp
47	typo

This revision is now accepted and ready to land.Jul 11 2020, 02:52

Closed by commit rABCdd13e82f8537: [avalanche] Change the addavalanchenode RPC so that it return if the operation… (authored by deadalnix). · Explain WhyJul 11 2020, 13:13

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCdd13e82f8537: [avalanche] Change the addavalanchenode RPC so that it return if the operation….

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

2 lines

processor.cpp

2 lines

test/

processor_tests.cpp

6 lines

rpc/

avalanche.cpp

6 lines

test/

functional/

abc_p2p_avalanche.py

4 lines

Diff 22215

View Options

src/avalanche/processor.h

View Options

src/avalanche/processor.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/rpc/avalanche.cpp

View Options

test/functional/abc_p2p_avalanche.py

[avalanche] Change the addavalanchenode RPC so that it return if the operation succeededClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22215

src/avalanche/processor.h

src/avalanche/processor.cpp

src/avalanche/test/processor_tests.cpp

src/rpc/avalanche.cpp

test/functional/abc_p2p_avalanche.py

[avalanche] Change the addavalanchenode RPC so that it return if the operation succeeded
ClosedPublic
Actions

Revision Contents
Changeset List