Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC3f95b1f4baf5: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp

Summary

There's no need to have this member live on CChainState since it's only used
in validation.cpp.

https://github.com/bitcoin/bitcoin/pull/16194/commits/55d525ab9004631d30dcc60a1ec5d9cd6c6afe56

Depends on D6967

Partial backport of Core PR16194

Test Plan

ninja check && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12086
Build 24135: Default Diff Build & Tests	build-diff
Build 24134: Build without Wallet	build-without-wallet
Build 24133: Build with clang-10	build-clang-10
Build 24132: arc lint + arc unit

Event Timeline

majcosta created this revision.Jul 17 2020, 21:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2020, 21:18

majcosta requested review of this revision.Jul 17 2020, 21:18

Harbormaster completed remote builds in B12053: Diff 22347.Jul 17 2020, 21:18

Why add more global state? Isn't it some state related to the chain?

This revision now requires changes to proceed.Jul 17 2020, 22:14

majcosta added a child revision: D6970: [backport#16194] refactoring: remove mapBlockIndex global.Jul 17 2020, 22:34

majcosta edited the summary of this revision. (Show Details)Jul 17 2020, 22:46

this is still encapsulation theatre, since both members are still public. but at least they're on just one place now and considering PR scope, it's a start

Harbormaster completed remote builds in B12069: Diff 22372.Jul 20 2020, 17:25

deadalnix accepted this revision.Jul 21 2020, 10:28

This revision is now accepted and ready to land.Jul 21 2020, 10:28

You are correct, you can remove it from chainstate and match core.

This revision now requires changes to proceed.Jul 21 2020, 10:29

reverted to match the PR more closely

Harbormaster completed remote builds in B12086: Diff 22400.Jul 21 2020, 16:25

deadalnix accepted this revision.Jul 22 2020, 14:18

This revision is now accepted and ready to land.Jul 22 2020, 14:18

rebase

Harbormaster completed remote builds in B12872: Diff 23702.Sep 22 2020, 23:15

Closed by commit rABC3f95b1f4baf5: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp (authored by James O'Beirne <james.obeirne@gmail.com>, committed by majcosta). · Explain WhySep 22 2020, 23:54